| commit | 3b68811ff9544a610ccc1c239701ae166e84912e | [log] [tgz] |
|---|---|---|
| author | Sigmund Cherem <sigmund@google.com> | Wed Nov 08 18:43:51 2023 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Wed Nov 08 10:46:21 2023 -0800 |
| tree | 56ecc5d128822724e4c7c26cd26b28b2c30728b0 | |
| parent | ebd98342a27447e50a4db3bf46dc38fbc24ab148 [diff] |
[tests] Mark closure/cycles_test as slow on chrome, skip on firefox. Eventually we may want to revisit whether it is worth running this test at all on the web backends. The test was designed to ensure the VM didn't produce memory leaks when capturing state in closures, as such, it may be better placed on a different suite. Today, the test passes in most web configurations. The two exceptions are: * ddc-linux-chrome is flaky and times out 50% of the time * ddc-linux-firefox consistently times out. Locally, on a machine much faster than our bots, the former completes in 5s and the latter in 25s. In the last 60 days, the chrome configuration has seen runs on the bots ranging from 8 to 60s (hitting the timeout). I expect marking the test as slow will fix the flakiness on chrome, but given that it is 5 times slower on FF, I fear it may not be enough to make the test pass in FF. Given that it doesn't provide much value to also have the coverage in FF, I'm inclined to skip it there instead. Change-Id: Ice25eb401b6af3c6ab8ba3f4b43bf3ce9ee38c83 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335020 Reviewed-by: Nicholas Shahan <nshahan@google.com> Commit-Queue: Sigmund Cherem <sigmund@google.com> https://dart.googlesource.com/sdk/+/0a0dcce390172210e405d9a4b035cf4ecf8c1137
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.