[analyzer] Break dependency between analyzer message codegen and analyzer. This fixes a bootstrapping problem: previously we could get into a situation where the generated files for analyzer diagnostic messages were out of date, but the code generator for those messages couldn't be run, because it imported the analyzer itself, which contained compiled errors due to the generated files being out of date. There were two problematic dependencies: - The `GeneratedContent.check` and `GeneratedContent.checkAll` methods relied on invoking the Dart formatter as a library (rather than invoking `dart format` as a subprocess); the Dart formatter library imports the analyzer. Fortunately, this functionality is not needed by the code generators themselves. It's only needed by the _tests_ that verify that code generation has run. So I was able to break the dependency by moving this functionality into a new file, `package:analyzer_utilities/generated_content_check.dart`, which is imported only by the code generation tests. The new API is slightly different: `GeneratedContent.checkAll` has been replaced by an extension method `check` on `Iterable<GeneratedContent>`. - The diagnostic message code generator used to have a post-processing step that made use of the scanner to find error messages used by the parser that needed to be translated, and issued a warning if it found any. This check was useful a long time ago, when we were unifying the analyzer and CFE parsers, and is no longer useful, so I've removed it. Change-Id: I509b741faca3b9ae21c23936001105ded731b490 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442241 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Paul Berry <paulberry@google.com> https://dart.googlesource.com/sdk/+/6610e5cbfe432b1d6d256454b132c82adb94827a
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.