| commit | 37fd6b04177e2bdfed79287d62aa816806920de7 | [log] [tgz] |
|---|---|---|
| author | Derek Xu <derekx@google.com> | Wed Jun 18 08:21:15 2025 -0700 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Wed Jun 18 09:06:53 2025 -0700 |
| tree | bc048dc21e968896ade65e02f7c608b1a3dcb56c | |
| parent | 2f03b9650ab3534a51fc945caada426fa825a4b8 [diff] |
Revert "Reland "[VM/Service] Shut down the VM immediately after the VM Service fails to start during VM initialization"" This reverts commit c2095cb34719a4fb2a4987b32264c06cb3e35873. Reason for revert: These changes are blocking the Dart SDK -> Flutter roll because they cause some Fuchsia tests to fail. Original change's description: > Reland "[VM/Service] Shut down the VM immediately after the VM Service fails to start during VM initialization" > > This reverts commit d510876d9e44fd13913ce49567ceb3059d7f38df. > > Reason for revert: g3 and Golem have been made compatible with this CL. > See b/409535026 and > https://chrome-internal-review.googlesource.com/c/golem/+/8345341. > > TEST=pkg/vm_service/test/failure_to_start_vm_service_after_vm_is_initialized_test, > pkg/vm_service/test/failure_to_start_vm_service_during_vm_initialization_test > > Original change's description: > > Revert "[VM/Service] Shut down the VM immediately after the VM Service fails to start during VM initialization" > > > > This reverts commit 56ccf437e6bbe696ada53c715c456a10e4863cd9. > > > > Reason for revert: b/409535026 > > > > TEST=ci > > > > Original change's description: > > > [VM/Service] Shut down the VM immediately after the VM Service fails to start during VM initialization > > > > > > TEST=pkg/vm_service/test/failure_to_start_vm_service_after_vm_is_initialized_test, > > > pkg/vm_service/test/failure_to_start_vm_service_during_vm_initialization_test > > > > > > Fixes: https://github.com/dart-lang/sdk/issues/60256 > > > Change-Id: I0543ab26e5721a4048136f27e8f4429bef04920f > > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/416300 > > > Commit-Queue: Derek Xu <derekx@google.com> > > > Reviewed-by: Ben Konyi <bkonyi@google.com> > > > > Change-Id: I61eb42f0f00ad97e95e3ebf19990fe75d2d416aa > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/421622 > > Reviewed-by: Derek Xu <derekx@google.com> > > Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com> > > Reviewed-by: Ben Konyi <bkonyi@google.com> > > Change-Id: Ieba880b7b298e491055c3f6049bab6772b1f8aa3 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434960 > Reviewed-by: Ben Konyi <bkonyi@google.com> > Commit-Queue: Derek Xu <derekx@google.com> No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I03b2371728de91e4e20008a879280c1ccab4d07c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/435540 Reviewed-by: Alexander Markov <alexmarkov@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Derek Xu <derekx@google.com> https://dart.googlesource.com/sdk/+/b3c579d3eeda62b2a1db4dad71b7383dd80629ec
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.