| commit | 343b04051fe549223de7b87dfcbc00c9769b1289 | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Thu Sep 12 16:30:22 2024 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Thu Sep 12 09:31:31 2024 -0700 |
| tree | 3aa8471929038ac76fcc423a3c21e645175872a1 | |
| parent | cd990f66b35d56d48ff7e039a0818073c2cae591 [diff] |
Properly report unreachable switch cases containing `when` clauses. When determining whether a switch statement is exhaustive, it's important for the exhaustiveness algorithm to ignore cases containing `when` clauses, since a `when` clause creates the possiblity that the case won't match. Previously, the way this was done in the analyzer was for the `SpaceCreator.createRootSpace` method to create an unknown space for cases containing `when` clauses. This approach produced the correct behavior when determining whether the switch statement as a whole was exhaustive, but since it discarded information about the pattern being matched, it limited the ability to determine whether an individual case was reachable, leading to https://github.com/dart-lang/sdk/issues/56710. To fix this, `SpaceCreator.createRootSpace` is changed so that it always produces a space that describes the case pattern, regardless of whether a `when` clause is present, and instead, `computeExhaustiveness` is responsible for ensuring that the case is properly excluded from the determination of whether the switch is exhaustive. This allows `computeExhaustiveness` to properly computate whether each individual case is reachable, even for cases that have `when` clauses. This change in approach produced some minor differences in the test cases in `pkg/_fe_analyzer_shared/test/exhaustiveness/data`, but these differences are not user-observable. Fixes https://github.com/dart-lang/sdk/issues/56710. Change-Id: I36629a77c4c1832fb1b8abb6ea7b109e0ca14373 Bug: https://github.com/dart-lang/sdk/issues/56710 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/384326 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Paul Berry <paulberry@google.com> https://dart.googlesource.com/sdk/+/a3c696fa5841a5cc82da56562bdb5da6be541cf0
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.