[messages] Disambiguate recordLiteralOnePositionalNoTrailingCommaByType. Renames the diagnostic code `CompileTimeErrorCode.recordLiteralOnePositionalNoTrailingComma` to `CompileTimeErrorCode.recordLiteralOnePositionalNoTrailingCommaByType`. This avoids an ambiguity between this message and `ParserErrorCode.recordLiteralOnePositionalNoTrailingComma`. The two messages need to stay distinct, because one is reported during parsing, and the other is reported during type analysis. Only `ParserErrorCode.recordLiteralOnePositionalNoTrailingComma` should prevent the formatter from running. Avoiding ambiguities like these is important, because in many cases the user only sees the diagnostic name; they don't see the class it's in. For example, `ignore:` comments just give the diagnostic name, and the web page https://dart.dev/tools/diagnostics only shows diagnostic names. In the future I intend to add an error check to the analyzer diagnostic code generator, to ensure that there are no ambiguities like these. This CL is a prerequisite for adding the error check. Note that the `sharedName` of the renamed diagnostic remains `RECORD_LITERAL_ONE_POSITIONAL_NO_TRAILING_COMMA`, so there will be no change in how the error is presented to the user. Change-Id: I6a6a6964c1d4e28c6db71072252abf95fbc13206 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/455562 Reviewed-by: Johnni Winther <johnniwinther@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Paul Berry <paulberry@google.com> https://dart.googlesource.com/sdk/+/3e23d1d4dd57de4f64e2190f40765eab221ee436
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.