Fine. Compute and persist LibraryManifest.hashForRequirements

Introduce a stable, order-independent hash derived from exactly the
parts of a library manifest that the requirements checker reads. This
hash is stored on each `LibraryManifest` (`hashForRequirements`) and
serialized as part of the binary format. When unchanged, it serves as a
fast path to skip the detailed `RequirementsManifest.isSatisfied` walk;
when it differs, the full check is re-run.

Key details:
- Hash content covers:
  - Library identity and flags (name, `isSynthetic`, `featureSet`),
    language versions (package/override), and `libraryMetadata.id`.
  - Export surface (sorted `exportedLibraryUris`, re-export
    `deprecatedOnly` names).
  - All declared top-level items; for instance/Interface items also hash
    members, inherited constructors, `hasNonFinalField`, and the
    interface id.
  - Export map id and entries, and exported extension ids.
- Determinism is ensured by sorting map entries by `LookupName` and
  lists before hashing.
- New helpers on `ApiSignature` (`addList`, `addMapEntryList`) simplify
  writing length-prefixed sequences.
- The manifest printer now shows the requirements hash as a compact
  `#H*` identifier to aid debugging.
- Binary format change bumps `AnalysisDriver.DATA_VERSION` to 563.

This change provides a cheap, deterministic indicator for whether a
library’s manifest remains equivalent for requirements checking,
reducing unnecessary revalidation while preserving correctness.

Change-Id: If00778bac077e2bd36a480ca0475ad356bc1d822
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/451663
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

https://dart.googlesource.com/sdk/+/a314f6e24f80da79dd32514cef76a3b76b290030
2 files changed
tree: 7fb6e540d82f79aabc3a79f36b797cea1103a1ec
  1. engine/
  2. tools/
  3. .gitignore
  4. commits.json
  5. DEPS
  6. OWNERS
  7. README.md
README.md

Monorepo

A gclient solution for checking out Dart and Flutter source trees

Monorepo is:

  • Optimized for Tip-of-Tree testing: The Monorepo DEPS used to check out Dart and Flutter dependencies comes from the Flutter engine DEPS with updated dependencies from Dart.

Checking out Monorepo

With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:

mkdir monorepo
cd monorepo
gclient config --unmanaged https://dart.googlesource.com/monorepo
gclient sync -D

This gives you a checkout in the monorepo directory that contains:

monorepo/
  DEPS - the DEPS used for this gclient checkout
  commits.json - the pinned commits for Dart, flutter/engine,
                 and flutter/flutter
  tools/ - scripts used to create monorepo DEPS
engine/src/ - the flutter/buildroot repo
    flutter/ - the flutter/engine repo
    out/ - the build directory, where Flutter engine builds are created
    third_party/ - Flutter dependencies checked out by DEPS
      dart/ - the Dart SDK checkout.
        third_party - Dart dependencies, also used by Flutter
flutter/ - the flutter/flutter repo

Building Flutter engine

Flutter's instructions for building the engine are at Compiling the engine

They can be followed closely, with a few changes:

  • Googlers working on Dart do not need to switch to Fuchsia's Goma RBE, except for Windows. The GOMA_DIR enviroment variable can just point to the .cipd_bin directory in a depot_tools installation, and just goma_ctl ensure_start is sufficient.
  • The --no-prebuilt-dart-sdk option has to be added to every gn command, so that the build is set up to build and use a local Dart SDK.
  • The --full-dart-sdk option must be added to gn for the host build target if you will be building web or desktop apps.

Example build commands that work on linux:

MONOREPO_PATH=$PWD
if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then
  PATH=$MONOREPO_PATH/flutter/bin:$PATH
fi

export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin
goma_ctl ensure_start

pushd engine/src
flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk
autoninja -C out/host_debug_unopt
popd

Building Flutter apps

The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.

For example, to build and run the Flutter spinning square sample on the web platform,

MONOREPO_PATH=$PWD
cd flutter/examples/layers
flutter --local-engine=host_debug_unopt \
  -d chrome run widgets/spinning_square.dart
cd $MONOREPO_PATH

To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command

flutter create --platforms=windows,macos,linux

on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter

Testing

Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:

MONOREPO_PATH=$PWD
cd flutter/packages/flutter
flutter test --local-engine=host_debug_unopt
cd $MONOREPO_PATH

Troubleshooting

Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.

We will update this documentation to address them.

  • flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.

Windows

  • On Windows, gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.