[dart2js/ddc/dart2wasm/dart:js_interop] Support SharedArrayBuffers in JS typed data wrappers https://github.com/dart-lang/sdk/issues/56455 The existing native typed data implementation in dart2js/ddc and the JS typed data wrappers in dart2wasm do not support SharedArrayBuffers. In dart2js/ddc, this is because the native type for ByteBuffer is simply ArrayBuffer, leading to type failures when using SharedArrayBuffers. To handle this, this change makes NativeByteBuffer an abstract parent class to NativeArrayBuffer and NativeSharedArrayBuffer. This allows ByteBuffer to support both types. There is a preexisting SharedArrayBuffer type in dart:html that we should avoid breaking, so we add an interface that NativeSharedArrayBuffer implements and expose that interface. In dart2wasm, JSArrayBufferImpl only allows ArrayBuffers as its extern ref. This change makes that wrapper support SharedArrayBuffers as well. In dart:js_interop, the existing toJS conversion on ByteBuffer now throws if the underlying buffer was actually a SharedArrayBuffer. This is to support the return type of JSArrayBuffer. This behavior technically already existed due to type differences in the JS compilers, but was never possible with dart2wasm. CoreLibraryReviewExempt: Backend-specific libraries with no real functional changes to public APIs. Change-Id: I4dac9fb808590bf0c274da815c152cd4637316b1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/437526 Reviewed-by: Stephen Adams <sra@google.com> Commit-Queue: Srujan Gaddam <srujzs@google.com> https://dart.googlesource.com/sdk/+/67bda7c22b16254819345420cb293cc5ef58c4bf
diff --git a/DEPS b/DEPS index 0c5cbe9..7511531 100644 --- a/DEPS +++ b/DEPS
@@ -229,7 +229,7 @@ ] deps = { - 'flutter/engine/src/flutter/third_party/dart': Var('dart_git') + '/sdk' + '@' + '482a7caed773bb8e6655808db4384ac90d76d89b', + 'flutter/engine/src/flutter/third_party/dart': Var('dart_git') + '/sdk' + '@' + '67bda7c22b16254819345420cb293cc5ef58c4bf', 'flutter': Var('flutter_git') + '/mirrors/flutter' + '@' + 'a04fb324be734cf18811c30c06baf9bf07b3bab3',
diff --git a/commits.json b/commits.json index 2cf23a4..8fc0324 100644 --- a/commits.json +++ b/commits.json
@@ -1,4 +1,4 @@ { "flutter":"a04fb324be734cf18811c30c06baf9bf07b3bab3", - "flutter/engine/src/flutter/third_party/dart":"482a7caed773bb8e6655808db4384ac90d76d89b" + "flutter/engine/src/flutter/third_party/dart":"67bda7c22b16254819345420cb293cc5ef58c4bf" } \ No newline at end of file