Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions) (#38827)

* Roll Skia from dfb838747295 to 9e51c2c9e231 (26 revisions)

https://skia.googlesource.com/skia.git/+log/dfb838747295..9e51c2c9e231

2023-01-12 kjlubick@google.com Roll CanvasKit to 0.38.0
2023-01-12 jonahwilliams@google.com Allow clients to cache sample count and stencil params
2023-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0a9529c8cd2d to 4053bc460f32 (6 revisions)
2023-01-12 herb@google.com Fix stack alignment for SkAutoSTArray
2023-01-12 kjlubick@google.com Remove SkBudgeted in favor of skgpu::Budgeted
2023-01-12 johnstiles@google.com Implement comma operator in RP codegen.
2023-01-12 johnstiles@google.com Allow cloning from another stack with an offset-from-top.
2023-01-12 fmalita@chromium.org [skottie] Initial text editing experiment
2023-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 46e3e213b046 to 1f9e50edd4d4 (9 revisions)
2023-01-12 kjlubick@google.com [base] Fold GrConfig.h into SkTypes.h
2023-01-12 kjlubick@google.com Break out metal headers used by C++ and ObjC code
2023-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 77e7d61086a2 to 65176286ea26
2023-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 154fb3872c36 to 0a9529c8cd2d (9 revisions)
2023-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from eab5947427ad to 410d8ba51f95 (17 revisions)
2023-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8bedae1a44a2 to 77e7d61086a2 (4 revisions)
2023-01-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 410b5acc7f3f to 46e3e213b046 (14 revisions)
2023-01-12 kyslov@google.com jpegr codec: get image origin from EXIF metadata
2023-01-12 ccameron@chromium.org Enable Jpeg gainmaps on Android
2023-01-11 johnstiles@google.com Add transpose support to RP codegen.
2023-01-11 johnstiles@google.com Add transpose support to the RP builder.
2023-01-11 jvanverth@google.com Some fixes to address null color attachment crash.
2023-01-11 johnstiles@google.com Create a RP transpose op, based on swizzle.
2023-01-11 kjlubick@google.com Remove two shim files
2023-01-11 kjlubick@google.com [canvaskit] Fix return value of Paragraph ranges
2023-01-11 kjlubick@google.com Disable JpegGainmapTest on WASM build
2023-01-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 93e4d1cd4725 to 154fb3872c36 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,herb@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* Adjust to changes to CanvasKit getRectsForRange API.

* remove unused commit

* Roll CIPD CanvasKit and fix some unit tests.

* Adjustments to direction API and unit tests.

Co-authored-by: Jackson Gardner <jacksongardner@google.com>
Co-authored-by: jonahwilliams <jonahwilliams@google.com>
https://dart.googlesource.com/external/github.com/flutter/engine/+/15d59792ebfb24425f9daafb8fe6d87eea1523e1
2 files changed
tree: b1c6d591b6e87ad815b8ef697fb53cd6ffc8e05b
  1. ci/
  2. tools/
  3. .gitignore
  4. commits.json
  5. DEPS
  6. README.md
README.md

Monorepo

A gclient solution for checking out Dart and Flutter source trees

Monorepo is:

  • Optimized for Tip-of-Tree testing: The Monorepo DEPS used to check out Dart and Flutter dependencies comes from the Flutter engine DEPS with updated dependencies from Dart.

Checking out Monorepo

With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:

mkdir monorepo
cd monorepo
gclient config --unmanaged https://dart.googlesource.com/monorepo
gclient sync -D

This gives you a checkout in the monorepo directory that contains:

monorepo/
  DEPS - the DEPS used for this gclient checkout
  commits.json - the pinned commits for Dart, flutter/engine,
                 and flutter/flutter
  tools/ - scripts used to create monorepo DEPS
engine/src/ - the flutter/buildroot repo
    flutter/ - the flutter/engine repo
    out/ - the build directory, where Flutter engine builds are created
    third_party/ - Flutter dependencies checked out by DEPS
      dart/ - the Dart SDK checkout.
        third_party - Dart dependencies, also used by Flutter
flutter/ - the flutter/flutter repo

Building Flutter engine

Flutter's instructions for building the engine are at Compiling the engine

They can be followed closely, with a few changes:

  • Googlers working on Dart do not need to switch to Fuchsia's Goma RBE, except for Windows. The GOMA_DIR enviroment variable can just point to the .cipd_bin directory in a depot_tools installation, and just goma_ctl ensure_start is sufficient.
  • The --no-prebuilt-dart-sdk option has to be added to every gn command, so that the build is set up to build and use a local Dart SDK.
  • The --full-dart-sdk option must be added to gn for the host build target if you will be building web or desktop apps.

Example build commands that work on linux:

MONOREPO_PATH=$PWD
if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then
  PATH=$MONOREPO_PATH/flutter/bin:$PATH
fi

export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin
goma_ctl ensure_start

pushd engine/src
flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk
autoninja -C out/host_debug_unopt
popd

Building Flutter apps

The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.

For example, to build and run the Flutter spinning square sample on the web platform,

MONOREPO_PATH=$PWD
cd flutter/examples/layers
flutter --local-engine=host_debug_unopt \
  -d chrome run widgets/spinning_square.dart
cd $MONOREPO_PATH

To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command

flutter create --platforms=windows,macos,linux

on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter

Testing

Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:

MONOREPO_PATH=$PWD
cd flutter/packages/flutter
flutter test --local-engine=host_debug_unopt
cd $MONOREPO_PATH

Troubleshooting

Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.

We will update this documentation to address them.

  • flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.

Windows

  • On Windows, gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.