Fine. Rename binary I/O types to BinaryReader/Writer
Replace the generic names `SummaryDataReader` and `BufferedSink` with
clearer `BinaryReader` and `BinaryWriter`. The new names reflect their
actual roles (reading/writing the analyzer’s binary formats), reduce
confusion with “summary” artifacts, and make call sites easier to scan.
No encoding or behavioral changes are intended.
Key changes
- Introduce `BinaryReader` and `BinaryWriter` and update class docs.
- Rename constructor, method, and factory signatures across the codebase
to use the new types (e.g., `read(...)`, `write(...)`, `fork(...)`).
- Update extensions to match the new names (`BinaryReaderExtension`,
`BinaryWriterExtension`) and migrate helper methods accordingly.
- Adjust `string_table.dart` to take `BinaryWriter` and update `_writeWtf8`.
- Update readers/writers throughout analyzer components:
- library context/diagnostics, unlinked data, manifests, IDs, items,
types, requirements, and informative data.
- utilities for `EnumSet.read`/`write`.
- summary2 bundle reader/writer and package bundle format.
- Keep `_SummaryDataWriter` as an internal adapter now extending
`BinaryWriter`.
Compatibility
- Binary format is unchanged; this is a pure rename refactor.
- Endianness, variable-length encodings, and offsets remain identical.
Change-Id: I97c07a708c1bd649084fc78a7c60c583964109ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/450950
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
https://dart.googlesource.com/sdk/+/9a720bb27af0e73bed06ce1186c778acd495b554
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.