| commit | 283f1c359490e832812aec6dbb993668b5479241 | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Mon Jul 07 17:52:16 2025 -0700 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Mon Jul 07 17:54:21 2025 -0700 |
| tree | 59b559b33c56c80fae0b6102757f9220a2784769 | |
| parent | e11db389ff0a3e6deba41554a2972c05bcb635b2 [diff] |
[_fe_analyzer_shared] Code generate ScannerErrorCode class. I suspect that the reason this wasn't previously code generated was because even though it follows the conventions of the other analyzer error code classes, and is used by the analyzer, it exists in `pkg/_fe_analyzer_shared`, since it is used by the scanner. In order for this to be code generated without creating a reverse dependency from `_fe_analyzer_shared` to `analyzer`, I had to change the code generator so that the generated files import `package:_fe_analyzer_shared/src/base/errors.dart` rather than `package:analyzer/error/error.dart`. This is a benign change so I went ahead and let it apply to all code generated by the analyzer error message code generator, even though it's only strictly necessary for code generated into the `_fe_analyzer_shared` package. Since code in `pkg/_fe_analyzer_shared` is required to use explicit `new` or `const` when constructing class instances, and since this coding convention is enforced by a custom CFE-based lints that doesn't understand `ignore:` comments, I also had to modify the code generator to insert the appropriate `const` keywords when generating the new code. To reduce churn and confusion, I added the `const` keywords only to error code classes inside `pkg/_fe_analyzer_shared`. I also had to improve the code generator so that it properly escapes `$` if it appears inside an error message. Previously, this was not a problem, because there were no code generated error messages that contained `$`. In the process of making this change, I discovered that entries for `ScannerErrorCode.UNEXPECTED_SEPARATOR_IN_NUMBER` were missing from `error_fix_status.yaml` and from the `diagnosticCodeValues` list. I've added the missing entries as part of the CL. Change-Id: Ib6e734a47e77b406059df9cfdeff9e401f22bd88 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/439060 Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> https://dart.googlesource.com/sdk/+/9a251b4e75a200d102dcdf40f5e2b108840ef9eb
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.