| commit | 191f7163a8d9d45cfa0fd929d5bc0f9645b31fd3 | [log] [tgz] |
|---|---|---|
| author | Ivan Inozemtsev <iinozemtsev@google.com> | Mon Jul 01 18:30:28 2024 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Mon Jul 01 11:32:44 2024 -0700 |
| tree | 58068a7ebd0786a3696f2c4c32bd676fdad5bc41 | |
| parent | 8376642178484ca13bce21783a23b3e512e68f96 [diff] |
Revert "Reapply "[ Service ] Start DDS and serve DevTools when the VM service is started via dart:developer"" This reverts commit 44d44514761c06f201cf3d7277a558c5131e06e0. Reason for revert: b/350443042 Original change's description: > Reapply "[ Service ] Start DDS and serve DevTools when the VM service is started via dart:developer" > > In the previous version of this change, if the user had 'dart' on their > PATH and invoked 'dart compile js' (which spawns the VM service after > compilation completes), the VM service would attempt to spawn DDS using > './dart' as the executable path instead of 'dart'. This would result in > DDS failing to start, causing the VM to print an error and hang. > > This updated change checks to see if the parent directory of > `Platform.executable` is '.' and then verifies if './dart' exists or > not. If it doesn't, 'dart' is likely on the user's PATH and should be > used directly as the executable path. > > See https://github.com/dart-lang/sdk/issues/56087 for details. > > This reverts commit 4b88698e4814035a356e9f1a7e6b9a9167bfa94c. > > TEST=pkg/dds/test/control_web_server_starts_dds_with_dart_on_path_test.dart > > Change-Id: Id0f1dadd01d9202cbf7717f31393b43171cf3968 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373561 > Auto-Submit: Ben Konyi <bkonyi@google.com> > Reviewed-by: Derek Xu <derekx@google.com> > Commit-Queue: Ben Konyi <bkonyi@google.com> Change-Id: I424c4b91b0b108ae4c9dffa0059ed90c918897e3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/373744 Reviewed-by: Siva Annamalai <asiva@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Srujan Gaddam <srujzs@google.com> Commit-Queue: Siva Annamalai <asiva@google.com> Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com> https://dart.googlesource.com/sdk/+/3370a4e3936d49090e176bd509ba5a1fed3b74d3
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.