commit: 14bae4d3551cc15df84af80a2f182e9a20d34ed9
[log]
author: Devon Carew <devoncarew@google.com>
Tue Jan 02 23:03:57 2024 +0000
committer: dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com>
Tue Jan 02 15:05:36 2024 -0800
tree: 7751884097f5e2ad4136b3bc2817fe726d0bea0a
parent: 1cf898b3e67011dbececc4d9fa48de091ecaae78 [diff]

Revert "Bump http to 73b0b1c9ef2964c4619fd23068b8f60292e902c6"

This reverts commit 105cd96dc8fad9905d7e473dd9d97943ba2d589d.

Reason for revert: fails the HHH bot

Original change's description:
> Bump http to 73b0b1c9ef2964c4619fd23068b8f60292e902c6
>
> Changes:
> ```
> > git log --format="%C(auto) %h %s" f0a02f9..73b0b1c
>  https://dart.googlesource.com/http.git/+/73b0b1c Bump actions/labeler from 4.3.0 to 5.0.0 (1096)
>  https://dart.googlesource.com/http.git/+/15ec3ba Prepare to publish `package:cronet_http` as 1.0.0 (1087)
>  https://dart.googlesource.com/http.git/+/26e55c3 cronet_http: require android API level 28 (1088)
>  https://dart.googlesource.com/http.git/+/b10f448 [cronet_http] Enables CI for `cronet_http_embedded` (1070)
>  https://dart.googlesource.com/http.git/+/a5b8eec Prepare to publish cupertino 1.2.0 (1080)
>  https://dart.googlesource.com/http.git/+/c114aa0 Add a fake response for PNG images (1081)
>  https://dart.googlesource.com/http.git/+/db2cb76 Run web tests with wasm with dev Dart sdk (1078)
>  https://dart.googlesource.com/http.git/+/36f98e9 Fix a bug where BrowserClient was listed as requiring Flutter (1077)
>  https://dart.googlesource.com/http.git/+/db7f165 Provide an example of configuring IOClient with an HttpClient. (1074)
>  https://dart.googlesource.com/http.git/+/cd748b6 Document that runWithClient must be called for every isolate (1069)
>  https://dart.googlesource.com/http.git/+/f585947 Test persistentConnection with large request bodies (984)
>  https://dart.googlesource.com/http.git/+/7c05dde Add documentation for "no_default_http_client" (1068)
>  https://dart.googlesource.com/http.git/+/d8983fa Add support for setting headers for all requests (1060)
>  https://dart.googlesource.com/http.git/+/c90496e Document how to use replacement `Client` implementations (1063)
>  https://dart.googlesource.com/http.git/+/c8536e4 [http_client_conformance_tests] Updates to support wasm compilation (1064)
>  https://dart.googlesource.com/http.git/+/5dd5140 Bump actions/setup-java from 3 to 4 (1065)
>  https://dart.googlesource.com/http.git/+/064f510 misc cleanup of yaml files (1061)
>  https://dart.googlesource.com/http.git/+/22f52e2 Update pubspec.yaml to 0.4.2 (1059)
>  https://dart.googlesource.com/http.git/+/40a46d8 Fix a bug where cronet_http sends incorrect HTTP request methods (1058)
>  https://dart.googlesource.com/http.git/+/c125ed5 [http] Allow pkg:web v0.3.0 (1055)
>  https://dart.googlesource.com/http.git/+/9fb4cfa Update lints to latest, etc (1048)
>  https://dart.googlesource.com/http.git/+/5e84d9f Update platform-specific imports for wasm (1051)
>  https://dart.googlesource.com/http.git/+/8c9feb5 [http] Fix type cast for dart2wasm (1050)
>  https://dart.googlesource.com/http.git/+/a2f0b25 [http] use pkg:web, require Dart 3.2 (1049)
>
> ```
>
> Diff: https://dart.googlesource.com/http.git/+/f0a02f98f7c921e86ecc81c70f38bb6fbccc81b9..73b0b1c9ef2964c4619fd23068b8f60292e902c6/
> Change-Id: Id9e8032411f3c34bb2bdc0c22af35da6f2e34a88
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/344320
> Reviewed-by: Nate Bosch <nbosch@google.com>
> Commit-Queue: Devon Carew <devoncarew@google.com>

Change-Id: I85e990104531d6927bf711d3478815e6cd1fbfc5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/344420
Auto-Submit: Devon Carew <devoncarew@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>

https://dart.googlesource.com/sdk/+/f34bdc2da2a1897470430640ffe11d285fbfb44d

2 files changed

tree: 7751884097f5e2ad4136b3bc2817fe726d0bea0a

README.md

Monorepo

A gclient solution for checking out Dart and Flutter source trees

Monorepo is:

Optimized for Tip-of-Tree testing: The Monorepo DEPS used to check out Dart and Flutter dependencies comes from the Flutter engine DEPS with updated dependencies from Dart.

Checking out Monorepo

With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:

mkdir monorepo
cd monorepo
gclient config --unmanaged https://dart.googlesource.com/monorepo
gclient sync -D

This gives you a checkout in the monorepo directory that contains:

monorepo/
  DEPS - the DEPS used for this gclient checkout
  commits.json - the pinned commits for Dart, flutter/engine,
                 and flutter/flutter
  tools/ - scripts used to create monorepo DEPS
engine/src/ - the flutter/buildroot repo
    flutter/ - the flutter/engine repo
    out/ - the build directory, where Flutter engine builds are created
    third_party/ - Flutter dependencies checked out by DEPS
      dart/ - the Dart SDK checkout.
        third_party - Dart dependencies, also used by Flutter
flutter/ - the flutter/flutter repo

Building Flutter engine

Flutter's instructions for building the engine are at Compiling the engine

They can be followed closely, with a few changes:

Googlers working on Dart do not need to switch to Fuchsia's Goma RBE, except for Windows. The GOMA_DIR enviroment variable can just point to the .cipd_bin directory in a depot_tools installation, and just goma_ctl ensure_start is sufficient.
The --no-prebuilt-dart-sdk option has to be added to every gn command, so that the build is set up to build and use a local Dart SDK.
The --full-dart-sdk option must be added to gn for the host build target if you will be building web or desktop apps.

Example build commands that work on linux:

MONOREPO_PATH=$PWD
if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then
  PATH=$MONOREPO_PATH/flutter/bin:$PATH
fi

export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin
goma_ctl ensure_start

pushd engine/src
flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk
autoninja -C out/host_debug_unopt
popd

Building Flutter apps

The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.

For example, to build and run the Flutter spinning square sample on the web platform,

MONOREPO_PATH=$PWD
cd flutter/examples/layers
flutter --local-engine=host_debug_unopt \
  -d chrome run widgets/spinning_square.dart
cd $MONOREPO_PATH

To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command

flutter create --platforms=windows,macos,linux

on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter

Testing

Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:

MONOREPO_PATH=$PWD
cd flutter/packages/flutter
flutter test --local-engine=host_debug_unopt
cd $MONOREPO_PATH

Troubleshooting

Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.

We will update this documentation to address them.

flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.

Windows

On Windows, gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.