[messages] Add logic to generate analyzer diagnostics as top level constants. Modifies the analyzer diagnostic message code generation logic so that it's capable of generating diagnostic constants either: - As static constants inside `DiagnosticCode`-derived classes such as `CompileTimeErrorCode` - Or as top level constants inside of new files called `diagnostic.g.dart`. The behavior is controlled through the constant `generateTopLevelConstants`. This constant is currently `false`, which means that diagnostic constants are still generated as static constants inside `DiagnosticCode`-derived classes (as they have been for quite some time). This CL introduces the new `diagnostic.g.dart` files, but they are currently empty. In a follow-up CL I will flip the flag to `true` and re-run the code generation logic, and in a later CL, I'll remove the flag. The reason for spreading the work across multiple CLs is twofold: - To make code review easier - To make merge conflicts easier to deal with (since the flag flip CL can easily be regenerated if merge conflicts arise). Note that when the flag is set to `true`, static constants will still be generated to the `DiagnosticCode`-derived classes to avoid breaking code in the analyzer and related packages, but these constants will simply redirect to the constants in the new `diagnostic.g.dart` files. Change-Id: I6a6a696452d1a81a45010b374e898f0fa5fe5c9a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/461260 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Paul Berry <paulberry@google.com> https://dart.googlesource.com/sdk/+/77e32275a7a360981b31bead0292d3e257806d7f
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.