[vm,dyn_modules] Add native entry fallbacks for FFI callback creation.
In compiled code, static calls to FFI callback creation functions are
replaced with different IL, so those functions should never be called
from compiled code and so the code assigned to them always errors.
For the creation of callbacks in interpreted JIT code, this CL replaces
the always-erroring definitions with native entries that check that the
caller is interpreted and running in JIT mode and, if so, creates an FFI
callback and returns it. In AOT mode and for other callers, the native
entry returns an error as before.
This CL also weakens the return check for native entries when dynamic
modules are enabled to allow for returning Function objects as well as
Instances. These FFI callback creation functions are only called from
transformed code, and so the returned Function object is consumed in
the transformed code and never returned to user code.
There are still some issues remaining with isolate group bound
callbacks and async callbacks that are exposed by removing the
"This function should be handled at the callsite." error. Those
will be addressed in followups.
TEST=RTE->Pass:
ffi/function_callbacks
ffi/isolate_local_function_callbacks
ffi/vmspecific_function_callbacks
ffi/native_callables
(and many more)
RTE->Crash:
ffi/async_void_function_callbacks
ffi/isolate_group_bound_callback
ffi/vmspecific_handle_test
ffi/regress_jump_to_frame
ffi/threading_reentrant_test
RTE->Timeout:
ffi/threading_test
Cq-Include-Trybots: luci.dart.try:vm-dyn-linux-debug-x64-try,vm-dyn-mac-debug-arm64-try
Change-Id: I4e5c9d76c2720db8543b835c81d5f317b1811cb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/525281
Commit-Queue: Tess Strickland <sstrickl@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
https://dart.googlesource.com/sdk/+/1e37c5edb00f2a28ab624f35ba7b7f77276facce
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.