Reland "[vm,dart2bytecode,modular_aot] Variable-length closure objects" This is a reland of commit 88496ba1c37fb6f67eac5920adb37eb8af0ee1f1 Fixes on top of the original change: * Closure layout is changed to avoid gap between fixed fields and variable-length elements on compressed pointers architecture. This gap was causing crashes in the GC when scanning closure objects. * pkg/vm_snapshot_analysis/test/instruction_sizes_test is fixed on arm64 by decreasing threshold for detecting size changes. Original change's description: > [vm,dart2bytecode,modular_aot] Variable-length closure objects > > Extend closure objects with variable number of elements to capture. > This is needed to support capturing multiple independent contexts > after capturing is computed in the front-end. > > The following fixed Closure fields are moved into variable-length > elements: > - delayed type arguments; > - instantiator type arguments; > - function type arguments; > - context. > > Number of elements and presence/indices of various type arguments > are encoded into the new length_and_flags field in the Closure. > > Most closure objects don't need any of the type arguments so this > change will reduce average Closure object size. TEST=ci Issue: https://github.com/dart-lang/sdk/issues/61572 Issue: https://github.com/dart-lang/sdk/issues/61635 Change-Id: I8685e632e2d0832766ecdc470f3cf9a6b880de48 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/494243 Commit-Queue: Alexander Markov <alexmarkov@google.com> Reviewed-by: Tess Strickland <sstrickl@google.com> Reviewed-by: Slava Egorov <vegorov@google.com> https://dart.googlesource.com/sdk/+/51d1c8923ae90bf089d836ece352c3562b9ba752
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.