commit d535c31e6780a7e792d611cd0e6b88b49d4146c5
author srawlins <srawlins@google.com> Fri Jul 02 13:40:52 2021 -0400
committer Sam Rawlins <sam.rawlins@gmail.com> Thu Jul 15 10:33:40 2021 -0700
tree 1b76ab85039c7ee16586d38cd0abd61b3a5cdeb3
parent 042673e014216979a6ce764e966f2cf9e20893c9

Explicitly declare a Future<void> when using Future.value

The inference_failure_on_instance_creation error will trigger on code like

```
returnValueForMissingStub: Future.value()
```

because, even though no value has been given to `value()`, that does not
affect the Future's type (it still defaults to `void`). Explicitly using
`Future<void>.value()` satisfies the check.

PiperOrigin-RevId: 382770034

lib/src/builder.dart

diff --git a/lib/src/builder.dart b/lib/src/builder.dart
index fea64b0..0b23589 100644
--- a/lib/src/builder.dart
+++ b/lib/src/builder.dart
@@ -1007,7 +1007,8 @@
     if (method.returnType.isVoid) {
       returnValueForMissingStub = refer('null');
     } else if (method.returnType.isFutureOfVoid) {
-      returnValueForMissingStub = _futureReference().property('value').call([]);
+      returnValueForMissingStub =
+          _futureReference(refer('void')).property('value').call([]);
     }
     final fallbackGenerator = fallbackGenerators[method.name];
     final namedArgs = {

test/builder/auto_mocks_test.dart

diff --git a/test/builder/auto_mocks_test.dart b/test/builder/auto_mocks_test.dart
index 4b132da..a1aaa60 100644
--- a/test/builder/auto_mocks_test.dart
+++ b/test/builder/auto_mocks_test.dart
@@ -526,7 +526,7 @@
       _containsAllOf(dedent2('''
       _i3.Future<void> m() => (super.noSuchMethod(Invocation.method(#m, []),
           returnValue: Future<void>.value(),
-          returnValueForMissingStub: Future.value()) as _i3.Future<void>);
+          returnValueForMissingStub: Future<void>.value()) as _i3.Future<void>);
       ''')),
     );
   });