| commit | 9bcfd827edd0040fd45fe02026b0a1769c0f1171 | [log] [tgz] |
|---|---|---|
| author | Alexander Markov <alexmarkov@google.com> | Wed May 27 16:52:30 2020 +0000 |
| committer | dart-luci-ci-builder <dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com> | Wed May 27 09:53:29 2020 -0700 |
| tree | 38d0242934c7aad799e05ad6a6825d03e12eee4d | |
| parent | 5de339fca7ef14d5d364ee16eb28436c87ae7fd5 [diff] |
Reland "[vm/aot] Enable tree-shaking of write-only fields by default" This is a reland of 9c50efcf072b653c669827545c654d6a2d408a7a There are no changes to the original CL. Fixes for bugs revealed by this change are in separate CLs: * Crash in disassembler https://dart-review.googlesource.com/c/sdk/+/148942 * Crash in --print_instructions_sizes_to https://dart-review.googlesource.com/c/sdk/+/149043 Original change's description: > [vm/aot] Enable tree-shaking of write-only fields by default > > Tree-shaking of write only fields is implemented in > https://dart-review.googlesource.com/c/sdk/+/143286 > This change just enables it by default. > > Flutter gallery in release mode > armv7 app.so size -0.41% (gzip -0.24%, brotli -0.20%) > armv8 app.so size -0.38% (gzip -0.23%, brotli -0.29%) > > Issue: https://github.com/dart-lang/sdk/issues/35310 > > Change-Id: Iaae3e893b4a6bf4d468d6cd05aba5f8ee8810afc > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148543 > Reviewed-by: Ryan Macnak <rmacnak@google.com> > Commit-Queue: Alexander Markov <alexmarkov@google.com> Change-Id: I609db3fec8b0798f55aa2067127dfdc90a21ead4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149044 Reviewed-by: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com> https://dart.googlesource.com/sdk/+/dae51f08d172b3cec0ecd318a6af30cbb7f19933