| commit | 4fb345d1d597948421c395d793a379ceac0f0e7f | [log] [tgz] |
|---|---|---|
| author | Sigurd Meldgaard <sigurdm@google.com> | Tue Dec 01 13:11:16 2020 +0000 |
| committer | dart-luci-ci-builder <dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com> | Tue Dec 01 06:04:50 2020 -0800 |
| tree | be966bbd1e172e53d36acbcc72b7e4567cf81a8a | |
| parent | 70774516ceca526a67af99db086d7e3ab7fede9e [diff] |
Revert "Improve handling of disable-dartdev-analytics" This reverts commit 58860f4814fb8bd36d0ebd580425a773ea7ede8c. Reason for revert: Broke bots. Will investigate. Original change's description: > Improve handling of disable-dartdev-analytics > > This is second try of https://dart-review.googlesource.com/c/sdk/+/171284 > that was reverted to to faulty logic in main_options. > > Some other refactorings are piggy-backed along. > > TestProject.runSync no longer takes a 'command' argument. It was anyway > often not an argument. > > Also stop the messy handling of pub arguments. It is no longer needed. > > BUG: https://github.com/dart-lang/sdk/issues/44135 > Change-Id: I49abf5810d9ea262409ba9d93f0471037cb8a753 > TEST=The VM change is tested via all the pkg/dartdev/test/command/* tests that invoke dart with the --no-analytics flag. > TEST=Furthermore manual test that the --no-analytics flag is passed to dartdev. > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174261 > Reviewed-by: Jonas Jensen <jonasfj@google.com> > Commit-Queue: Sigurd Meldgaard <sigurdm@google.com> TBR=bkonyi@google.com,sigurdm@google.com,jonasfj@google.com Change-Id: I754bcebdcfc595158b04d431662b65bf25f5b89d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174466 Reviewed-by: Sigurd Meldgaard <sigurdm@google.com> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com> https://dart.googlesource.com/sdk/+/97baa6efd187c0eaec6a1dfd53984300588a0101