tree 4be264a0efdcc920150c12e8dbef5a7aae68755c
parent 60db5f0fefe09b5a51d234dfa72e9197d9257d30
author Alexander Markov <alexmarkov@google.com> 1558654822 +0000
committer dart-luci-ci-builder <dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com> 1558654951 -0700

[vm] Do expensive kernel metadata verification only once per kernel

In DEBUG mode during AOT compilation MetadataHelper::SetMetadataMappings
may spend considerable time verifying that node offsets are sorted
in kernel metadata. The problem is that there are a lot of MetadataHelpers
created (several per each compiled function).

This change moves verification of kernel metadata mappings to
the kernel loader, so it is performed only once per kernel program.

AOT gen_snapshot time on a small test:
Before: 11.680s
After: 9.041s

Change-Id: I1c0a676b0ed28fc5cfa756ca60159f914190fac0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103486
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>

https://dart.googlesource.com/sdk/+/49262365dc2981549889103d033a15b8f6ccbb7b