tree 510648ceeee79a6ff507e5b2a93da978015a88f5
parent a693b10b667410971fa6ca12baac0b0939f72ad3
author Sigurd Meldgaard <sigurdm@google.com> 1606818355 +0000
committer dart-luci-ci-builder <dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com> 1606818455 -0800

Improve handling of disable-dartdev-analytics

This is second try of https://dart-review.googlesource.com/c/sdk/+/171284
that was reverted to to faulty logic in main_options.

Some other refactorings are piggy-backed along.

TestProject.runSync no longer takes a 'command' argument. It was anyway
often not an argument.

Also stop the messy handling of pub arguments. It is no longer needed.

BUG: https://github.com/dart-lang/sdk/issues/44135
Change-Id: I49abf5810d9ea262409ba9d93f0471037cb8a753
TEST=The VM change is tested via all the pkg/dartdev/test/command/* tests that invoke dart with the --no-analytics flag.
TEST=Furthermore manual test that the --no-analytics flag is passed to dartdev.
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174261
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>

https://dart.googlesource.com/sdk/+/58860f4814fb8bd36d0ebd580425a773ea7ede8c