| commit | 034e737bf6866c3d99eb8d2aa2eb776e3542788e | [log] [tgz] |
|---|---|---|
| author | Vyacheslav Egorov <vegorov@google.com> | Wed May 27 10:06:49 2020 +0000 |
| committer | dart-luci-ci-builder <dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com> | Wed May 27 03:08:00 2020 -0700 |
| tree | a5ded57946f85d895ac875ba5f57b2e4947e4a44 | |
| parent | 14e78036992a3e5c5bb5172b3d1e5687e85bf020 [diff] |
[vm/compiler] Fix code determining if object can be a smi in LoadClassId. Previous variant of the code did not handle FutureOr<T> and Comparable<U> correctly - variables of these types can contain a smi value if T can be a subclass of num or if U can be num. Rename HasNonSmiAssignableInterface to CanReceiverBeSmiBasedOnInterfaceTarget to better conway its meaning. Fixes https://github.com/flutter/flutter/issues/57398 Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-linux-debug-x64-try Change-Id: I67b29908e057632e62c46fb327a5c805fcc78d74 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149063 Commit-Queue: Vyacheslav Egorov <vegorov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> https://dart.googlesource.com/sdk/+/7175ab7329953d10d0894ae7d1921fbdd76a85f2