appengine: throw AssetErrors directly (instead of via new Future.error
Future closures wrap these correctly
Also: updated code review settings
R=kustermann@google.com
Review URL: https://codereview.chromium.org//710093005
diff --git a/pkgs/appengine/codereview.settings b/pkgs/appengine/codereview.settings
index 6b7c986..9eb3211 100644
--- a/pkgs/appengine/codereview.settings
+++ b/pkgs/appengine/codereview.settings
@@ -1,3 +1,3 @@
-CODE_REVIEW_SERVER: https://chromereviews.googleplex.com
+CODE_REVIEW_SERVER: http://codereview.chromium.org/
VIEW_VC: https://github.com/dart-lang/appengine/commit/
-CC_LIST: prometheus-dart-reviews@google.com
+CC_LIST: prometheus-dart-reviews@google.com, reviews@dartlang.org
diff --git a/pkgs/appengine/lib/src/server/assets.dart b/pkgs/appengine/lib/src/server/assets.dart
index caf5829..d5591d8 100644
--- a/pkgs/appengine/lib/src/server/assets.dart
+++ b/pkgs/appengine/lib/src/server/assets.dart
@@ -47,10 +47,10 @@
return proxyResponse.pipe(request.response);
})
.catchError((e) {
+ // TODO(kevmoo) Use logging here
print("Unable to connect to 'pub serve' for '${request.uri}': $e");
- var error = new AssetError(
+ throw new AssetError(
"Unable to connect to 'pub serve' for '${request.uri}': $e");
- return new Future.error(error);
});
}
@@ -74,10 +74,9 @@
if (response.statusCode == HttpStatus.OK) {
return response;
} else {
- var error = new AssetError(
+ throw new AssetError(
"Failed to fetch asset '$path' from pub: "
"${response.statusCode}.");
- return new Future.error(error);
}
})
.catchError((error) {
@@ -85,7 +84,7 @@
error = new AssetError(
"Failed to fetch asset '$path' from pub: '${path}': $error");
}
- return new Future.error(error);
+ throw error;
});
}
@@ -95,8 +94,7 @@
if (exists) {
return new File(root + path).openRead();
} else {
- var error = new AssetError("Asset '$path' not found");
- return new Future.error(error);
+ throw new AssetError("Asset '$path' not found");
}
});
}
