tree 36aa2f28bceb8dcd6c1520ef89619138097d8d32
parent 413ee9d1d1841c23ebfd2248abc4fc950e0d6946
author Nate Bosch <nbosch1@gmail.com> 1597188229 -0700
committer GitHub <noreply@github.com> 1597188229 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJfMyiFCRBK7hj4Ov3rIwAAdHIIAAOmpNO8INDhOCJiSi2fNViJ
 xht9aeRBrEJUnlvIKV8DD99DJkQaN9Z8olChwS37Fy7JEn6QCFS42RDdnBdCekJs
 RlqKSpZIR8IQPFuFlxZbrI90EIFwGtV+kohmvqh3uaIrzgI/W4eTOPHF5Wfjd6vX
 /hySbb3rhVElB8r19bYvzFufMbWDyC0E8Pwm3hfumEKFyj8HavFQxGtnnzjChubD
 pLa/x70vPEw9OauHZlsnpizZ+yWAXOLHrQ7+CklP7Bh8KU/XaXrYJ/9tXgmfH3nL
 h+alV7vsEkJllcpcNFBQeN0/ix47/mIN7Yj5utH/JgJ88E572WGtJL/8+ddphlU=
 =q1zh
 -----END PGP SIGNATURE-----
 

Avoid an open Peer with a closed Client (#65)

May fix https://github.com/dart-lang/sdk/issues/43012

If a `Peer` is created with a `StreamChannel` that does not follow the
stated contract it's possible that the `sink` gets closed without
receiving a done event from the `channel` which leaves the `Peer`
instance in a state that's inconsistent with the underlying `Client`.
The result is that it's possible to get a bad state trying to send a
message even with `isClosed` returns `false`.

- Make `isClosed` and `done` forward to the `_client` and `_peer` fields
  so that they can't be inconsistent.
- Forward errors to the `_server` so that it can forward them through
  `done` without an extra `Completer` to manage.
- Avoid closing the `sink` in the `Peer`. It will end up being closed by
  the server when it is handling the error, and it's the same `sink`
  instance in both places.
- Add a test that ensures that `isClosed` behaves as expected following
  a call to `close()` even when the `StreamChannel` does not follow it's
  contract.