tree 533f17a0005484ea465a8be83d49b5cb1031eb0b
parent e29d2d496ef892b58ce78fd11b2de6fa0fdf5a0a
author copybara-service[bot] <copybara-servicebot@google.com> 1595335448 +0000
committer Kevin Moore <kevmoo@google.com> 1611173926 +0000

Avoid returning null from a factory method

With Null Safety factory constructors will not be allowed to return `null`
values. We could make this into a static method, but it seems that there
already is an assertion that the argument is of a specific type, so I thought
that we could simply make it into a check and throw `ArgumentError` for
unsupported types.

Here's the global presubmit:
http://test/OCL:321566434:BASE:322085661:1595227618340:70519a7c
and its deflake:
http://test/OCL:321566434:BASE:322085661:1595232479037:1d5b2f0f
(tl;dr: it seems that there are only a few timeouts of flaky tests)

Do let me know if you prefer the alternative of using a static method instead.

PiperOrigin-RevId: 322342435