Simplify test asserts and use lambdas (#175727)
<img width="761" height="223" alt="ag"
src="https://github.com/user-attachments/assets/e7a94876-a28f-4dd3-95f4-d0d2928913bc"
/>
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
diff --git a/engine/src/flutter/shell/platform/android/test/io/flutter/plugin/editing/ScribePluginTest.java b/engine/src/flutter/shell/platform/android/test/io/flutter/plugin/editing/ScribePluginTest.java
index 386c75a..8b77cc7 100644
--- a/engine/src/flutter/shell/platform/android/test/io/flutter/plugin/editing/ScribePluginTest.java
+++ b/engine/src/flutter/shell/platform/android/test/io/flutter/plugin/editing/ScribePluginTest.java
@@ -5,9 +5,10 @@
package io.flutter.plugin.editing;
import static io.flutter.Build.API_LEVELS;
-import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertThrows;
+import static org.junit.Assert.assertTrue;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
@@ -48,7 +49,7 @@
@TargetApi(API_LEVELS.API_34)
@Test
public void scribePluginIsFeatureAvailable() {
- assertEquals(scribePlugin.isFeatureAvailable(), true);
+ assertTrue(scribePlugin.isFeatureAvailable());
verify(mockImm).isStylusHandwritingAvailable();
}
@@ -57,7 +58,7 @@
@TargetApi(API_LEVELS.API_34)
@Test
public void scribePluginIsStylusHandwritingAvailable() {
- assertEquals(scribePlugin.isStylusHandwritingAvailable(), true);
+ assertTrue(scribePlugin.isStylusHandwritingAvailable());
verify(mockImm).isStylusHandwritingAvailable();
}
@@ -77,18 +78,14 @@
public void scribePluginStartStylusHandwritingWhenAPILevelUnsupported() {
assertNotNull(scribePlugin);
- assertThrows(
- NoSuchMethodError.class,
- () -> {
- scribePlugin.startStylusHandwriting();
- });
+ assertThrows(NoSuchMethodError.class, () -> scribePlugin.startStylusHandwriting());
}
@Config(sdk = API_LEVELS.API_33)
@TargetApi(API_LEVELS.API_33)
@Test
public void scribePluginIsFeatureAvailableWhenAPILevelUnsupported() {
- assertEquals(scribePlugin.isFeatureAvailable(), false);
+ assertFalse(scribePlugin.isFeatureAvailable());
}
@Config(sdk = API_LEVELS.API_33)
@@ -97,10 +94,6 @@
public void scribePluginIsStylusHandwritingAvailableWhenAPILevelUnsupported() {
assertNotNull(scribePlugin);
- assertThrows(
- NoSuchMethodError.class,
- () -> {
- scribePlugin.isStylusHandwritingAvailable();
- });
+ assertThrows(NoSuchMethodError.class, () -> scribePlugin.isStylusHandwritingAvailable());
}
}
