Isolates launched by the engine instance use the settings of that instance. (#22052)

This regression was introduced in https://github.com/flutter/engine/pull/21820
for sound-null safety. The settings used to launch the VM were incorrectly used
to determine the isolate lifecycle callbacks. Since the first shell/engine in
the process also starts the VM, these objects are usually identical. However,
for subsequent engine shell/engine launches, the callbacks attached to the new
settings object would be ignored. The unit-test harness is also structured in
such a way that each test case tears down the VM before the next. So all
existing tests created a bespoke VM for the test run, and, the tests that did
create multiple isolates did not also test attaching callbacks to the settings
object.

Fixes https://github.com/flutter/engine/pull/22041
5 files changed
tree: eddb59a00a95f04e8a5c829800b3bff8e303f84c
  1. .github/
  2. assets/
  3. benchmarking/
  4. build/
  5. ci/
  6. common/
  7. docs/
  8. e2etests/
  9. examples/
  10. flow/
  11. flutter_frontend_server/
  12. fml/
  13. lib/
  14. runtime/
  15. shell/
  16. sky/
  17. testing/
  18. third_party/
  19. tools/
  20. vulkan/
  21. web_sdk/
  22. .cirrus.yml
  23. .clang-format
  24. .clang-tidy
  25. .gitattributes
  26. .gitignore
  27. analysis_options.yaml
  28. AUTHORS
  29. BUILD.gn
  30. CONTRIBUTING.md
  31. DEPS
  32. Doxyfile
  33. LICENSE
  34. README.md
README.md

Flutter Engine

Build Status - Cirrus

Flutter is Google's mobile app SDK for crafting high-quality native interfaces in record time. Flutter works with existing code, is used by developers and organizations around the world, and is free and open source.

The Flutter Engine is a portable runtime for hosting Flutter applications. It implements Flutter's core libraries, including animation and graphics, file and network I/O, accessibility support, plugin architecture, and a Dart runtime and compile toolchain. Most developers will interact with Flutter via the Flutter Framework, which provides a modern, reactive framework, and a rich set of platform, layout and foundation widgets.

If you want to run/contribute to Flutter Web engine, more tooling can be found at felt. This is a tool written to make web engine development experience easy.

If you are new to Flutter, then you will find more general information on the Flutter project, including tutorials and samples, on our Web site at Flutter.dev. For specific information about Flutter's APIs, consider our API reference which can be found at the docs.flutter.dev.

Flutter is a fully open source project, and we welcome contributions. Information on how to get started can be found at our contributor guide.