)]}'
{
  "commit": "d72135133b9ae4d0623ba03efecc46cc038ba994",
  "tree": "43f4ab29efe7b36a535ce13681d0eaf0be20a318",
  "parents": [
    "302798a7ddc56016cebac1dc8f31339cf6b89cf6"
  ],
  "author": {
    "name": "Bruno Leroux",
    "email": "bruno.leroux@gmail.com",
    "time": "Thu Jun 20 21:21:47 2024 +0200"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Thu Jun 20 19:21:47 2024 +0000"
  },
  "message": "[Web] Fix extra new line when inputAction is not newline for a multil… (#53453)\n\n## Description\r\n\r\nThis PR prevents new line key event from being dispatched for a multiline text field when `TextField.textInputAction` is not `TextInputAction.newline`.\r\n\r\nSince https://github.com/flutter/engine/pull/33428, web engine does not prevent new line key events.\r\nIn https://github.com/flutter/engine/pull/36893, I fixed a similar issue for single line text fields. At that time I was not sure if we want to fix it for multiline text fields. I checked again on non-web platforms (macos, iOS, Android) and the new line is not added if the input action is not `TextInputAction.newline`.\r\n\r\nFor a **multiline field**, the default text input action is `TextInputAction.newline`.\r\nIf the developer sets text input action to another value:\r\n- before this PR, the action is performed and a new line is added.\r\n- after this PR, the action is performed but no new line is added.\r\n\r\n## Related Issue\r\n\r\nFixes https://github.com/flutter/flutter/issues/145051\r\n\r\n## Tests\r\n\r\nAdds 1 tests, updates 3 tests.",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "98b3400c5032dfb539d0b75ed735399bf8a40a4b",
      "old_mode": 33188,
      "old_path": "lib/web_ui/lib/src/engine/text_editing/text_editing.dart",
      "new_id": "f1c45b4b8fc58ccde84bf3d3fad6955e8b26e512",
      "new_mode": 33188,
      "new_path": "lib/web_ui/lib/src/engine/text_editing/text_editing.dart"
    },
    {
      "type": "modify",
      "old_id": "49b76226a6c87b4b581f10ed458d4b1c0ab874d4",
      "old_mode": 33188,
      "old_path": "lib/web_ui/test/engine/text_editing_test.dart",
      "new_id": "bea5f02bf0d66affa537ae4b1ddc52c915f35e40",
      "new_mode": 33188,
      "new_path": "lib/web_ui/test/engine/text_editing_test.dart"
    }
  ]
}