)]}' { "commit": "c3c7e33c69f0edb35c5589f7a5b8c34f1ebda967", "tree": "8690bf82d96bd814d95d4daa129528ce28c21737", "parents": [ "6192818802e735f0a36e51119ff7f4dc75356cef" ], "author": { "name": "Chris Bracken", "email": "chris@bracken.jp", "time": "Wed Aug 10 10:31:03 2022 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed Aug 10 18:31:03 2022 +0100" }, "message": "Support custom entrypoints in public Windows API (#35285)\n\nThis adds a dart_entrypoint field to FlutterDesktopEngineProperties in\r\nthe public C Windows API, which mirrors that in the embedder API.\r\n\r\nWhen a null or empty entrypoint is specified, a default entrypoint of\r\n\u0027main\u0027 is assumed. Otherwise, the app is launched at the top-level\r\nfunction specified, which must be annotated with\r\n@pragma(\u0027vm:entry-point\u0027) in the Dart source.\r\n\r\nThis change is backward-compatible for existing users of the Windows C API\r\nand the C++ client wrapper API. To avoid breaking backward compatibility,\r\nthis patch preserves the entry_point parameter to FlutterDesktopEngineRun\r\nin the public Windows C API as well as in the FlutterEngine::Run method\r\nin the C++ client wrapper API. The entrypoint can be specified in either\r\nthe engine properties struct or via the parameter, but if conflicting\r\nnon-empty values are specified, the engine launch will intentionally fail\r\nwith an error message.\r\n\r\nThis change has no effect on existing Flutter Windows desktop apps and no\r\nmigration is required, because our app templates never specify a custom\r\nentrypoint, nor was the option to specify one via the old method particularly\r\nfeasible, because the FlutterViewController class constructor immediately\r\ninvokes FlutterViewControllerCreate which immediately launches the engine\r\npassed to it with a null entrypoint argument, so long as the engine is not\r\nalready running. However, running the engine without a view controller\r\npreviously resulted in errors due to failure to create a rendering surface.\r\n\r\nThis is a followup patch to https://github.com/flutter/engine/pull/35273\r\nwhich added support for running Dart fixture tests with a live Windows\r\nembedder engine.\r\n\r\nFixes: https://github.com/flutter/flutter/issues/93537\r\nRelated: https://github.com/flutter/flutter/issues/87299", "tree_diff": [ { "type": "modify", "old_id": "27d2fedce3b854beb6cf12d7d8d2fa6d1e32599c", "old_mode": 33188, "old_path": "shell/platform/windows/accessibility_bridge_delegate_windows_unittests.cc", "new_id": "5db7fc4c7de38b7499495031bd76ac70bab75a60", "new_mode": 33188, "new_path": "shell/platform/windows/accessibility_bridge_delegate_windows_unittests.cc" }, { "type": "modify", "old_id": "e9130805c824fd708eeb2e4bbfcb86814913b8ba", "old_mode": 33188, "old_path": "shell/platform/windows/client_wrapper/flutter_engine.cc", "new_id": "f35c20cd9e5a229df4f2a579ee861c2042145653", "new_mode": 33188, "new_path": "shell/platform/windows/client_wrapper/flutter_engine.cc" }, { "type": "modify", "old_id": "e52fb336a3373cef813dfb220259297f8247eb45", "old_mode": 33188, "old_path": "shell/platform/windows/client_wrapper/flutter_engine_unittests.cc", "new_id": "6f09bb960aac5c1d2cfe42f8e9e862d0ba87d1a5", "new_mode": 33188, "new_path": "shell/platform/windows/client_wrapper/flutter_engine_unittests.cc" }, { "type": "modify", "old_id": "cbc07ff502359dee8676abc29fb5a666f58a55b3", "old_mode": 33188, "old_path": "shell/platform/windows/client_wrapper/include/flutter/dart_project.h", "new_id": "903cfc45e9299887302e66deca3cb50ec90aaf27", "new_mode": 33188, "new_path": "shell/platform/windows/client_wrapper/include/flutter/dart_project.h" }, { "type": "modify", "old_id": "688361740ebc85a2b4a76614fe84c3a18159e206", "old_mode": 33188, "old_path": "shell/platform/windows/client_wrapper/include/flutter/flutter_engine.h", "new_id": "897fccfe0eb94cbb2059412a9335d9025dbaccc7", "new_mode": 33188, "new_path": "shell/platform/windows/client_wrapper/include/flutter/flutter_engine.h" }, { "type": "modify", "old_id": "6d207279d54eebc4d743fa67026cf8198fe3e0db", "old_mode": 33188, "old_path": "shell/platform/windows/fixtures/main.dart", "new_id": "219c83e8eb6d5bcf4ea158ff57e727d1a2546adc", "new_mode": 33188, "new_path": "shell/platform/windows/fixtures/main.dart" }, { "type": "modify", "old_id": "d01ef65a17815f1958868615c71c43a3ea25e6a6", "old_mode": 33188, "old_path": "shell/platform/windows/flutter_project_bundle.cc", "new_id": "90b2d782d7d7ee7ef77befd3cc87846a6638fa47", "new_mode": 33188, "new_path": "shell/platform/windows/flutter_project_bundle.cc" }, { "type": "modify", "old_id": "3cb5d3ca616229ef7f4d60528afbe89893eff566", "old_mode": 33188, "old_path": "shell/platform/windows/flutter_project_bundle.h", "new_id": "09770b5c094fc5f4c386c5f314bf3795563fa5b6", "new_mode": 33188, "new_path": "shell/platform/windows/flutter_project_bundle.h" }, { "type": "modify", "old_id": "9e07ed003b6489fd63b6c704d999fa5e6ec9f242", "old_mode": 33188, "old_path": "shell/platform/windows/flutter_windows.cc", "new_id": "87c6c8bd55df4fb1f3a1d94674f5bbc2c8b6b6d3", "new_mode": 33188, "new_path": "shell/platform/windows/flutter_windows.cc" }, { "type": "modify", "old_id": "a1edfee1c46f34752a302aa9270065630b62e38b", "old_mode": 33188, "old_path": "shell/platform/windows/flutter_windows_engine.cc", "new_id": "a0358bb6090d8471b8892be8ab2cb1e373028221", "new_mode": 33188, "new_path": "shell/platform/windows/flutter_windows_engine.cc" }, { "type": "modify", "old_id": "71233c318524c3ef234fb55c46cad103f5da3d23", "old_mode": 33188, "old_path": "shell/platform/windows/flutter_windows_engine.h", "new_id": "1512870a4e71065673b8b2064c525068fa706494", "new_mode": 33188, "new_path": "shell/platform/windows/flutter_windows_engine.h" }, { "type": "modify", "old_id": "fad87e75e1846166cc3d8e50ed0e5ee5dc669ccd", "old_mode": 33188, "old_path": "shell/platform/windows/flutter_windows_engine_unittests.cc", "new_id": "191740f213ebdcbdd5fb6796a526bfd10d2fc30a", "new_mode": 33188, "new_path": "shell/platform/windows/flutter_windows_engine_unittests.cc" }, { "type": "modify", "old_id": "7b21046eac897b8bc9e85030960fd235f0c40677", "old_mode": 33188, "old_path": "shell/platform/windows/flutter_windows_unittests.cc", "new_id": "00520426c18978852bcf779f8db449e327942273", "new_mode": 33188, "new_path": "shell/platform/windows/flutter_windows_unittests.cc" }, { "type": "modify", "old_id": "cf823c6357718b5f59ea1bcc221fd563ad6fff8b", "old_mode": 33188, "old_path": "shell/platform/windows/flutter_windows_view_unittests.cc", "new_id": "9513322daa2b7093d3fb598b54daf98ac692f202", "new_mode": 33188, "new_path": "shell/platform/windows/flutter_windows_view_unittests.cc" }, { "type": "modify", "old_id": "f532c1a92af856c9439696a15f554d00c848a5a2", "old_mode": 33188, "old_path": "shell/platform/windows/keyboard_unittests.cc", "new_id": "4ce5ba4724e066f35fc0bb77e81b01c672bf9223", "new_mode": 33188, "new_path": "shell/platform/windows/keyboard_unittests.cc" }, { "type": "modify", "old_id": "b5d2738778e5a16249bf05f9a4a93905eb88479f", "old_mode": 33188, "old_path": "shell/platform/windows/public/flutter_windows.h", "new_id": "ca1655f1e9f4067c0f38496db5f524a52ac267c9", "new_mode": 33188, "new_path": "shell/platform/windows/public/flutter_windows.h" }, { "type": "modify", "old_id": "69843ea5bb061bbd16136220f6b1c265da24ee9f", "old_mode": 33188, "old_path": "shell/platform/windows/testing/windows_test_config_builder.cc", "new_id": "c3c2d0ecf968063453176a1e6db537e18235ebdf", "new_mode": 33188, "new_path": "shell/platform/windows/testing/windows_test_config_builder.cc" }, { "type": "modify", "old_id": "0a1bfb400002e8a09e79e381ba162fffe65ea101", "old_mode": 33188, "old_path": "shell/platform/windows/testing/windows_test_config_builder.h", "new_id": "33b2660b2f14759608561faceb44640337a2ad58", "new_mode": 33188, "new_path": "shell/platform/windows/testing/windows_test_config_builder.h" } ] }