)]}'
{
  "commit": "80cfd35743b7725f366a268e4d12ca43513851f1",
  "tree": "9e0301f0655a1443ef122a6674fa4b7f4bc3d33a",
  "parents": [
    "d43753394b3fd546ba5f0f6c53b828f1e5c15a1f"
  ],
  "author": {
    "name": "Jonah Williams",
    "email": "jonahwilliams@google.com",
    "time": "Fri Jan 12 12:22:11 2024 -0800"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Fri Jan 12 20:22:11 2024 +0000"
  },
  "message": "[Impeller] remove Buffer type and associated abstractions. (#49702)\n\nNow that the HostBuffer isn\u0027t implementing Buffer, there is really no reason to have a Buffer/DeviceBuffer split. make BufferViews use a DeviceBuffer, and remove the data ptr from buffer views (as we can always reach into the device buffer).\r\n\r\nMakes some other cleanups too, since we always use a std::shared_ptr\u003cDeviceBuffer\u003e, then we can eliminated the shared_from_this call for AsBufferView by making this a static method.",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "8b069e99fc686fae0a5e99e95de52acb42a9c136",
      "old_mode": 33188,
      "old_path": "ci/licenses_golden/licenses_flutter",
      "new_id": "65cf1c29188812a3b7a617c86ae53353c192519d",
      "new_mode": 33188,
      "new_path": "ci/licenses_golden/licenses_flutter"
    },
    {
      "type": "modify",
      "old_id": "71e2331cd457572f1ef46a1a2b4f2e035c93ecc7",
      "old_mode": 33188,
      "old_path": "impeller/base/backend_cast.h",
      "new_id": "a67e4e3dd866355914ec3dee046fdff38c4aab52",
      "new_mode": 33188,
      "new_path": "impeller/base/backend_cast.h"
    },
    {
      "type": "modify",
      "old_id": "36c7ddb5504ed19578fb47672d7fc6423e3c3b9b",
      "old_mode": 33188,
      "old_path": "impeller/core/BUILD.gn",
      "new_id": "2f15c1b28788e703a58f862235e0807601ac68ea",
      "new_mode": 33188,
      "new_path": "impeller/core/BUILD.gn"
    },
    {
      "type": "delete",
      "old_id": "b645939921f9126bdaca95efa13b6616b227b774",
      "old_mode": 33188,
      "old_path": "impeller/core/buffer.cc",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "df58b56c0c62c21c6903393febb2e8c7f536d222",
      "old_mode": 33188,
      "old_path": "impeller/core/buffer.h",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "551bb0b625e58800e688e0c240cd647e22ec11aa",
      "old_mode": 33188,
      "old_path": "impeller/core/buffer_view.h",
      "new_id": "e319f44f283599a1b9762a8306912abcefed88d3",
      "new_mode": 33188,
      "new_path": "impeller/core/buffer_view.h"
    },
    {
      "type": "modify",
      "old_id": "5c6ecf4077ed3ac57da51306d066efe4800a7ee4",
      "old_mode": 33188,
      "old_path": "impeller/core/device_buffer.cc",
      "new_id": "d7262e72b946666a2d710db16a3fd8933dbbf25e",
      "new_mode": 33188,
      "new_path": "impeller/core/device_buffer.cc"
    },
    {
      "type": "modify",
      "old_id": "7f0cb99f3ba3f7ddc917f4591542caee8e04319c",
      "old_mode": 33188,
      "old_path": "impeller/core/device_buffer.h",
      "new_id": "619069ddc717993d852865b6a94551c5234671f8",
      "new_mode": 33188,
      "new_path": "impeller/core/device_buffer.h"
    },
    {
      "type": "modify",
      "old_id": "1abc892116817681e529e3f03b19951a6e148dc0",
      "old_mode": 33188,
      "old_path": "impeller/core/host_buffer.cc",
      "new_id": "0752818256076414317e3076ba840cc4ef3e0bec",
      "new_mode": 33188,
      "new_path": "impeller/core/host_buffer.cc"
    },
    {
      "type": "modify",
      "old_id": "16c118093c3a2501534ff10d9374561752a45f68",
      "old_mode": 33188,
      "old_path": "impeller/core/host_buffer.h",
      "new_id": "4ed78d0c555c90cf0edccae703f8c8265b8feb59",
      "new_mode": 33188,
      "new_path": "impeller/core/host_buffer.h"
    },
    {
      "type": "modify",
      "old_id": "3e0a6d5aae845b54c52e409d2e472a61fcfad13a",
      "old_mode": 33188,
      "old_path": "impeller/entity/contents/test/contents_test_helpers.h",
      "new_id": "e5f33b19bdeefa9356954265dd8eb0e8815373e8",
      "new_mode": 33188,
      "new_path": "impeller/entity/contents/test/contents_test_helpers.h"
    },
    {
      "type": "modify",
      "old_id": "2b7a1af87bf2f69ce688ba2b4984833b7d0c8256",
      "old_mode": 33188,
      "old_path": "impeller/entity/geometry/point_field_geometry.cc",
      "new_id": "27369da784e1c5c1c55ca0107111ff8e85a71301",
      "new_mode": 33188,
      "new_path": "impeller/entity/geometry/point_field_geometry.cc"
    },
    {
      "type": "modify",
      "old_id": "1c6dbfa694b49cfbfe36e278356858941b173db3",
      "old_mode": 33188,
      "old_path": "impeller/playground/playground.cc",
      "new_id": "c4f4f1338c39125d8166a1d8ce793b8b6f89122a",
      "new_mode": 33188,
      "new_path": "impeller/playground/playground.cc"
    },
    {
      "type": "modify",
      "old_id": "168053efdbdd9e27a1b42b0ed368a952ed11fcd6",
      "old_mode": 33188,
      "old_path": "impeller/renderer/backend/gles/buffer_bindings_gles.cc",
      "new_id": "4be33ce6fcbf350e8214b7034c872e4ee6c881f0",
      "new_mode": 33188,
      "new_path": "impeller/renderer/backend/gles/buffer_bindings_gles.cc"
    },
    {
      "type": "modify",
      "old_id": "c13dbb196f627790e55901f6ae107d4a738fd81b",
      "old_mode": 33188,
      "old_path": "impeller/renderer/backend/gles/render_pass_gles.cc",
      "new_id": "20b6fd4bea71ba66924c1689477d476cefba6af8",
      "new_mode": 33188,
      "new_path": "impeller/renderer/backend/gles/render_pass_gles.cc"
    },
    {
      "type": "modify",
      "old_id": "150576699df62b92506776c247b52408979ee464",
      "old_mode": 33188,
      "old_path": "impeller/renderer/backend/metal/allocator_mtl.mm",
      "new_id": "dfae2502ea9fee4a515f8d6308413c83d3a7cdad",
      "new_mode": 33188,
      "new_path": "impeller/renderer/backend/metal/allocator_mtl.mm"
    },
    {
      "type": "modify",
      "old_id": "3f3f7c3fd18e798f5e1a8916711f0aadf56ee582",
      "old_mode": 33188,
      "old_path": "impeller/renderer/backend/metal/compute_pass_mtl.mm",
      "new_id": "5abab34389a31824e1b3f122b404a66a16d01051",
      "new_mode": 33188,
      "new_path": "impeller/renderer/backend/metal/compute_pass_mtl.mm"
    },
    {
      "type": "modify",
      "old_id": "936bc449e0a9cfaef3426aad7695404feeb28b49",
      "old_mode": 33188,
      "old_path": "impeller/renderer/backend/metal/device_buffer_mtl.h",
      "new_id": "63b5b6d21c758d6f46af4d67ce6daa7d4aeb9b57",
      "new_mode": 33188,
      "new_path": "impeller/renderer/backend/metal/device_buffer_mtl.h"
    },
    {
      "type": "modify",
      "old_id": "8b22881000defb40af729dbf3d4177265b05b436",
      "old_mode": 33188,
      "old_path": "impeller/renderer/backend/metal/render_pass_mtl.mm",
      "new_id": "83918f71fce846057962883954710c75137b19cc",
      "new_mode": 33188,
      "new_path": "impeller/renderer/backend/metal/render_pass_mtl.mm"
    },
    {
      "type": "modify",
      "old_id": "19fe5350d602b0e296dc487bd32a237cbb83787e",
      "old_mode": 33188,
      "old_path": "impeller/renderer/backend/vulkan/binding_helpers_vk.cc",
      "new_id": "cb399d9f23d1ba271aa52547acd82e1e81fcc331",
      "new_mode": 33188,
      "new_path": "impeller/renderer/backend/vulkan/binding_helpers_vk.cc"
    },
    {
      "type": "modify",
      "old_id": "260c9e4a458617045504ed54c7226004623a435a",
      "old_mode": 33188,
      "old_path": "impeller/renderer/backend/vulkan/blit_command_vk_unittests.cc",
      "new_id": "db4fbdf38bf9b6c8f1f251426d9eba3fe1980d57",
      "new_mode": 33188,
      "new_path": "impeller/renderer/backend/vulkan/blit_command_vk_unittests.cc"
    },
    {
      "type": "modify",
      "old_id": "31ab804027da9edd2bac245e630a810ac9917f01",
      "old_mode": 33188,
      "old_path": "impeller/renderer/backend/vulkan/command_encoder_vk.cc",
      "new_id": "4cd2284dc5cfc60a9770f4e71c9aace7566d810f",
      "new_mode": 33188,
      "new_path": "impeller/renderer/backend/vulkan/command_encoder_vk.cc"
    },
    {
      "type": "modify",
      "old_id": "4c682e8284884383af8fe4daef0791c93b0680fa",
      "old_mode": 33188,
      "old_path": "impeller/renderer/backend/vulkan/command_encoder_vk.h",
      "new_id": "3622447a3041b52a38a8fa4afb98d333773ca799",
      "new_mode": 33188,
      "new_path": "impeller/renderer/backend/vulkan/command_encoder_vk.h"
    },
    {
      "type": "modify",
      "old_id": "33182c52f31af0283343c9b9d99e3f49b95fd88d",
      "old_mode": 33188,
      "old_path": "impeller/renderer/backend/vulkan/device_buffer_vk.h",
      "new_id": "e5603c9b9051bb7957a0f9ad3d75ea2f7366af06",
      "new_mode": 33188,
      "new_path": "impeller/renderer/backend/vulkan/device_buffer_vk.h"
    },
    {
      "type": "modify",
      "old_id": "67066c0878d0cd117a78b70be0b42b8bfb51f8a1",
      "old_mode": 33188,
      "old_path": "impeller/renderer/backend/vulkan/render_pass_vk.cc",
      "new_id": "42254364a0ee39f9132282bea8db86b44a5bc7be",
      "new_mode": 33188,
      "new_path": "impeller/renderer/backend/vulkan/render_pass_vk.cc"
    },
    {
      "type": "modify",
      "old_id": "e93bec3b28f0fc88d2342e091c041e5a06842a4d",
      "old_mode": 33188,
      "old_path": "impeller/renderer/compute_subgroup_unittests.cc",
      "new_id": "49bc9ea9a17e95e93652c538d6ca2a59db186b23",
      "new_mode": 33188,
      "new_path": "impeller/renderer/compute_subgroup_unittests.cc"
    },
    {
      "type": "modify",
      "old_id": "1c6a22f2d77da94bd3e5d5df1a1bc0341e4e7771",
      "old_mode": 33188,
      "old_path": "impeller/renderer/compute_tessellator.cc",
      "new_id": "ebcf76d615d745a947d75571f2a507cd8574f10a",
      "new_mode": 33188,
      "new_path": "impeller/renderer/compute_tessellator.cc"
    },
    {
      "type": "modify",
      "old_id": "03eb2686806d5ee99482af8754099cbd3fc65250",
      "old_mode": 33188,
      "old_path": "impeller/renderer/compute_unittests.cc",
      "new_id": "ce416c65a0d2de4fcf02dd5ebe9bf75e3b3f3276",
      "new_mode": 33188,
      "new_path": "impeller/renderer/compute_unittests.cc"
    },
    {
      "type": "modify",
      "old_id": "dcc40359f9d27f73f337348ebf0b06f5111b5d83",
      "old_mode": 33188,
      "old_path": "impeller/renderer/renderer_unittests.cc",
      "new_id": "60514ce2347627c4c2cbcfb994677007cfa6075d",
      "new_mode": 33188,
      "new_path": "impeller/renderer/renderer_unittests.cc"
    },
    {
      "type": "modify",
      "old_id": "78a780bae143d969650f95d66f85c4d95e2c2033",
      "old_mode": 33188,
      "old_path": "impeller/renderer/vertex_buffer_builder.h",
      "new_id": "98ca5107cd8adbf06950d27f8fd8462306d24992",
      "new_mode": 33188,
      "new_path": "impeller/renderer/vertex_buffer_builder.h"
    },
    {
      "type": "modify",
      "old_id": "02380442984af98d58ad7fc048ae7f5087c7903a",
      "old_mode": 33188,
      "old_path": "lib/ui/painting/image_decoder_impeller.cc",
      "new_id": "e577b7ac7357e71a8a31b53f5cfbc9cc070944cd",
      "new_mode": 33188,
      "new_path": "lib/ui/painting/image_decoder_impeller.cc"
    },
    {
      "type": "modify",
      "old_id": "0801f7930d12d6b7ebe3e9f5f4fd07ad4d93443e",
      "old_mode": 33188,
      "old_path": "lib/ui/painting/image_encoding_impeller.cc",
      "new_id": "a0b61da066ded2d63e0b5dbba8511a8c3521729f",
      "new_mode": 33188,
      "new_path": "lib/ui/painting/image_encoding_impeller.cc"
    }
  ]
}