)]}' { "commit": "6cd85616b8cff8806f7ddb1cc32d990e3a5b97eb", "tree": "bc3cbf4be30d1dd3136bd53434df4e0126744bd9", "parents": [ "479bb736fefb6d39ae52ad949f0a8585aed402a4" ], "author": { "name": "Matej Knopp", "email": "matej.knopp@gmail.com", "time": "Wed Dec 14 20:40:56 2022 +0100" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed Dec 14 20:40:56 2022 +0100" }, "message": "[macOS] Refactor rendering infrastructure (#37789)\n\n* [macos] Refactor rendering process\r\n\r\n* Put includes and imports together\r\n\r\n* Update shell/platform/darwin/macos/framework/Source/FlutterCompositor.mm\r\n\r\nCo-authored-by: Chris Bracken \u003cchris@bracken.jp\u003e\r\n\r\n* Update shell/platform/darwin/macos/framework/Source/FlutterCompositor.mm\r\n\r\nCo-authored-by: Chris Bracken \u003cchris@bracken.jp\u003e\r\n\r\n* Update shell/platform/darwin/macos/framework/Source/FlutterCompositor.mm\r\n\r\nCo-authored-by: Chris Bracken \u003cchris@bracken.jp\u003e\r\n\r\n* Update shell/platform/darwin/macos/framework/Source/FlutterPlatformViewController.mm\r\n\r\nCo-authored-by: Chris Bracken \u003cchris@bracken.jp\u003e\r\n\r\n* Update shell/platform/darwin/macos/framework/Source/FlutterRenderer.mm\r\n\r\nCo-authored-by: Chris Bracken \u003cchris@bracken.jp\u003e\r\n\r\n* Remove cast\r\n\r\n* Do not manually add platform view layer to FlutterView\r\n\r\n* Remove unnecesary _Internal header files\r\n\r\n* Make surfaceManager a readonly property\r\n\r\n* Add comment\r\n\r\n* Style nit: Rewrite as a noun phrase.\r\n\r\n* Naming nit for consistency with removeSurfaceForSize:\r\n\r\n* Write as ternary conditional.\r\n\r\n* Fix plural in comment.\r\n\r\n* Offset and index are already set to 0.\r\n\r\n* Remove FlutterSurfaceManager lookupSurface\r\n\r\nAnd the associate bookkeeping of borrowed (lent) surfaces.\r\n\r\n* Update shell/platform/darwin/macos/framework/Source/FlutterThreadSynchronizer.mm\r\n\r\nCo-authored-by: Chris Bracken \u003cchris@bracken.jp\u003e\r\n\r\n* Update shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.mm\r\n\r\nCo-authored-by: Chris Bracken \u003cchris@bracken.jp\u003e\r\n\r\n* Update shell/platform/darwin/macos/framework/Source/FlutterSurfaceManagerTest.mm\r\n\r\nCo-authored-by: Chris Bracken \u003cchris@bracken.jp\u003e\r\n\r\n* Update shell/platform/darwin/macos/framework/Source/FlutterRenderer.mm\r\n\r\nCo-authored-by: Chris Bracken \u003cchris@bracken.jp\u003e\r\n\r\n* Update shell/platform/darwin/macos/framework/Source/FlutterSurfaceManagerTest.mm\r\n\r\nCo-authored-by: Chris Bracken \u003cchris@bracken.jp\u003e\r\n\r\n* Update shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.h\r\n\r\nCo-authored-by: Chris Bracken \u003cchris@bracken.jp\u003e\r\n\r\n* Update shell/platform/darwin/macos/framework/Source/FlutterSurfaceManagerTest.mm\r\n\r\nCo-authored-by: Chris Bracken \u003cchris@bracken.jp\u003e\r\n\r\n* Update shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.h\r\n\r\nCo-authored-by: Chris Bracken \u003cchris@bracken.jp\u003e\r\n\r\n* Update shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.h\r\n\r\nCo-authored-by: Chris Bracken \u003cchris@bracken.jp\u003e\r\n\r\n* Update shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.h\r\n\r\nCo-authored-by: Chris Bracken \u003cchris@bracken.jp\u003e\r\n\r\n* Fix build error\r\n\r\n* Address nits\r\n\r\n* Replace EVent with fml::AutoResetWaitableEvent\r\n\r\n* Remove unecessary CATransaction\r\n\r\n* Add GetRequiredFrameSize\r\n\r\nCo-authored-by: Chris Bracken \u003cchris@bracken.jp\u003e", "tree_diff": [ { "type": "modify", "old_id": "8e517e61ac41ce03d76dd5c207a76885704ba534", "old_mode": 33188, "old_path": "ci/licenses_golden/licenses_flutter", "new_id": "e4c6e82e0e05f9a7c10b521acc93c7b116887d33", "new_mode": 33188, "new_path": "ci/licenses_golden/licenses_flutter" }, { "type": "modify", "old_id": "935a3c3591978b0080bb156d0e6cdfd899495520", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/BUILD.gn", "new_id": "6dc6b79a9814661488505b503fc67de92a80d9ed", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/BUILD.gn" }, { "type": "modify", "old_id": "66cf7b8939d37eedcab626232e169bdc638728bc", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterCompositor.h", "new_id": "99983e8ddb9bf335ecd02b44d9a8aa3bb1dd26d0", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterCompositor.h" }, { "type": "modify", "old_id": "ccdfaec180c2a677a7089588e682ad7a86ac450b", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterCompositor.mm", "new_id": "d71f5accafab47fec2a75527c10e2258187492c5", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterCompositor.mm" }, { "type": "modify", "old_id": "576af2bbac1526d41ed4968f33e13f61e866bcae", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterCompositorTest.mm", "new_id": "bd6bf4d57b58b345ded11185108d60422217f59f", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterCompositorTest.mm" }, { "type": "modify", "old_id": "19ed29aa1171ca70f8c8510605eb681563c40b3a", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterEngine.mm", "new_id": "870ca4802f3d9311df6ff472e3692eb047194bff", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterEngine.mm" }, { "type": "modify", "old_id": "143b05b7ced8ebdbc33ff09a39c676cd398ade41", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm", "new_id": "ad7535c83f1576aa34490f199a6fd6575a0a27fc", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm" }, { "type": "delete", "old_id": "e3a1f8a7113dd0992fbbdfc367ddf2a4ca46fae4", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterIOSurfaceHolder.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "d8553507442f90cabb003b711c2cc8fc5c9dc86a", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterIOSurfaceHolder.mm", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "b15b1ca5ebd423b5d87d5b415f65057e52c243c2", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterPlatformViewController.mm", "new_id": "ac01ef57bc1cfcffd16e9f0663058a25813ecd0b", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterPlatformViewController.mm" }, { "type": "modify", "old_id": "d9cbe1da5abb0df3a5c727c921edd1074258c4c4", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterRenderer.h", "new_id": "483a858032bc8105fb210ac60e9f7728fc82891f", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterRenderer.h" }, { "type": "modify", "old_id": "996e613dba9266495be01fa0572bff2fd3d94dcb", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterRenderer.mm", "new_id": "007a3cce157a5da1bfabef0a3e9b7c3b89d2cd05", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterRenderer.mm" }, { "type": "modify", "old_id": "6cd57e33d48f9451af2287a0ba2afa88884e4289", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterRendererTest.mm", "new_id": "01146e1464c02737d8298f80017f0a057000267d", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterRendererTest.mm" }, { "type": "delete", "old_id": "00a93ac2130783140e2dd6efa60e697a5a6c13e9", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterResizableBackingStoreProvider.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "436d41af68f156242b50aa825194d3366616bc38", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterResizableBackingStoreProvider.mm", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "556856ed3684db27a65a81d9195e7ccfa31e7627", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterResizeSynchronizer.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "7681aa33857796846a4e73cf935222e0ea46b6c4", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterResizeSynchronizer.mm", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "697bd29dee81c23f91b2bacc2a5705f0cee02718", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterSurface.h" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "4b65f2553c31551fa5c489062d72733dc10c5278", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterSurface.mm" }, { "type": "modify", "old_id": "2f6a0974e416452c4cbcbc64b0d1a87354c1839e", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.h", "new_id": "da1e2bcc9b9882c3caad3c1cac22b6b76fe3824f", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.h" }, { "type": "modify", "old_id": "d3d612fd294c80b3b2bb3fe7b867801d02e2b502", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.mm", "new_id": "50d7be11117da6e9504a22ab28f012a780372a2c", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterSurfaceManager.mm" }, { "type": "modify", "old_id": "b9e1742abd5471cc3a671006bbbca1cad2be0278", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterSurfaceManagerTest.mm", "new_id": "058913ae2e6f856e711dc53288475672a5c4076e", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterSurfaceManagerTest.mm" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "8eca9611f0f4868c5a38ec15b9eb0c20a6f33981", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterThreadSynchronizer.h" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "10f9ae53e5ccea8b0053471f08df5c48ac7da3f9", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterThreadSynchronizer.mm" }, { "type": "modify", "old_id": "2da2f48f34963b4ea3bfdfd7158097a26fce1eaf", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterView.h", "new_id": "ba70833b46b76b2c69d5f7b71b64c601f37462d5", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterView.h" }, { "type": "modify", "old_id": "8a92b9f5fbb59f613889ce84b7606fc3d1b8f1af", "old_mode": 33188, "old_path": "shell/platform/darwin/macos/framework/Source/FlutterView.mm", "new_id": "9991918153dfab6b88e76cb9a7e6435fa4130f76", "new_mode": 33188, "new_path": "shell/platform/darwin/macos/framework/Source/FlutterView.mm" } ] }