)]}'
{
  "commit": "40d7aaafee63a2b4b1503b783a530a8e9b54b8ef",
  "tree": "5b534c024a6430c86997b781dbb1514497962657",
  "parents": [
    "1314faf00cb9ab0234531dc63a281d07f1d861dc"
  ],
  "author": {
    "name": "auto-submit[bot]",
    "email": "98614782+auto-submit[bot]@users.noreply.github.com",
    "time": "Wed Jun 05 14:26:47 2024 +0000"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Wed Jun 05 14:26:47 2024 +0000"
  },
  "message": "Reverts \"[ios][platform_view] Use CAShapeLayer as the mask to avoid software rendering  (#53072)\" (#53220)\n\nReverts: flutter/engine#53072\nInitiated by: jason-simmons\nReason for reverting: compilation errors on iOS targets\r\n\r\n```\r\nFlutterPlatformViews_Internal.mm:277:10: error: ARC forbids explicit message send of \u0027dealloc\u0027\r\n  277 |   [super dealloc];\r\n      |    ~~~~~ ^\r\n ```\r\n\r\n(see https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8746006425774972161/+/u/build_ci_ios_debug_unopt_sim_flutter_testing_scenario_app_flutter_shell_platform_darwin_ios:ios_test_flutter/st\nOriginal PR Author: hellohuanlin\n\nReviewed By: {cbracken, jonahwilliams}\n\nThis change reverts the following previous change:\nThis PR uses `CAShapeLayer` as the mask to avoid software rendering. \r\n\r\nI kept `UIView` as the mask, so that we can measure just the improvement related to avoiding software rendering. This also allows me to land this change sooner. I created [a separate issue](https://github.com/flutter/flutter/issues/149212) to track removing UIView as the mask. \r\n\r\nNote: the previous behavior seems to be incorrect (or at least not pixel perfect). This PR fixed it. See comments. \r\n\r\nSee design doc: https://docs.google.com/document/d/1TqG_N4GK_qctuk73Gk3zOdAiILUrwMqxoCMgroK_AeA/edit?resourcekey\u003d0-jUiidfzIS642ngG2w9vSUA\u0026tab\u003dt.0\r\n\r\n*List which issues are fixed by this PR. You must list at least one issue.*\r\n\r\nFixes https://github.com/flutter/flutter/issues/142813\r\nFixes https://github.com/flutter/flutter/issues/142830\r\n\r\n*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*\r\n\r\n[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "8a65d7c1cff161091e32d2ece70ae03aaa05593b",
      "old_mode": 33188,
      "old_path": "shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsTest.mm",
      "new_id": "7b4c82d8d5c7ed7e689afb571e16ac260afe3587",
      "new_mode": 33188,
      "new_path": "shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsTest.mm"
    },
    {
      "type": "modify",
      "old_id": "9596435974244f98de3b729e1c5481b2a6fb0eef",
      "old_mode": 33188,
      "old_path": "shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.mm",
      "new_id": "859544e119a520114cfa7c6c9ef38ea00759a810",
      "new_mode": 33188,
      "new_path": "shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.mm"
    },
    {
      "type": "modify",
      "old_id": "7ea1bc41705236711aef8a08eced38aa6da3c98f",
      "old_mode": 33188,
      "old_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_clippath_iPhone SE (3rd generation)_17.0_simulator.png",
      "new_id": "2bebde1df95ce7b0f653576cf2a2718ff6499700",
      "new_mode": 33188,
      "new_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_clippath_iPhone SE (3rd generation)_17.0_simulator.png"
    },
    {
      "type": "modify",
      "old_id": "02d912869b2a4f955465dabcabadce99025f07cd",
      "old_mode": 33188,
      "old_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_clippath_with_transform_iPhone SE (3rd generation)_17.0_simulator.png",
      "new_id": "8b6157a9ee92b6021bee282932193533a88018ec",
      "new_mode": 33188,
      "new_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_clippath_with_transform_iPhone SE (3rd generation)_17.0_simulator.png"
    },
    {
      "type": "modify",
      "old_id": "8d206240351dabc7aa097c95860e262ff413ad69",
      "old_mode": 33188,
      "old_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprect_after_moved_iPhone SE (3rd generation)_17.0_simulator.png",
      "new_id": "f550dafa6a86d931308c287c8c80fa3a5983a74f",
      "new_mode": 33188,
      "new_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprect_after_moved_iPhone SE (3rd generation)_17.0_simulator.png"
    },
    {
      "type": "modify",
      "old_id": "80d7b7da3739c192927bceaa315944fc538a6911",
      "old_mode": 33188,
      "old_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprect_with_transform_iPhone SE (3rd generation)_17.0_simulator.png",
      "new_id": "9204afaccbd1abfa5166a0d47e4656ba5586441f",
      "new_mode": 33188,
      "new_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprect_with_transform_iPhone SE (3rd generation)_17.0_simulator.png"
    },
    {
      "type": "modify",
      "old_id": "bbdf631e40b641317c367702dd40fc3b9b1a8d35",
      "old_mode": 33188,
      "old_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprrect_iPhone SE (3rd generation)_17.0_simulator.png",
      "new_id": "864e2e4cc6312224b249f6912872f9fb0c08e063",
      "new_mode": 33188,
      "new_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprrect_iPhone SE (3rd generation)_17.0_simulator.png"
    },
    {
      "type": "modify",
      "old_id": "3402fa41765261f53e138953cfe042104887a593",
      "old_mode": 33188,
      "old_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprrect_with_transform_iPhone SE (3rd generation)_17.0_simulator.png",
      "new_id": "f099ea658da1087a7ec6263010d3a8d0d905394d",
      "new_mode": 33188,
      "new_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_cliprrect_with_transform_iPhone SE (3rd generation)_17.0_simulator.png"
    },
    {
      "type": "modify",
      "old_id": "f91b63d8c75e1aa645be6d4def39410464b8fade",
      "old_mode": 33188,
      "old_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_large_cliprrect_iPhone SE (3rd generation)_17.0_simulator.png",
      "new_id": "e7b071aa7b4e0fe86d7861a8176ff0d2bf9b4657",
      "new_mode": 33188,
      "new_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_large_cliprrect_iPhone SE (3rd generation)_17.0_simulator.png"
    },
    {
      "type": "modify",
      "old_id": "177d0c817fdb0b1baa58123541d2933292afd5e0",
      "old_mode": 33188,
      "old_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_large_cliprrect_with_transform_iPhone SE (3rd generation)_17.0_simulator.png",
      "new_id": "46af77aaf34a771855d18e253bc57c7f4a664002",
      "new_mode": 33188,
      "new_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_platform_view_large_cliprrect_with_transform_iPhone SE (3rd generation)_17.0_simulator.png"
    },
    {
      "type": "modify",
      "old_id": "f93545135c81281bc2015e50d1c2f0b5c823abd5",
      "old_mode": 33188,
      "old_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_path_iPhone SE (3rd generation)_17.0_simulator.png",
      "new_id": "cb1d6c12423cb201f28cffbd4ae8a8710d7c0dd1",
      "new_mode": 33188,
      "new_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_path_iPhone SE (3rd generation)_17.0_simulator.png"
    },
    {
      "type": "modify",
      "old_id": "49f7cadbbfecefd4563eb8642f1f4bcac47d2979",
      "old_mode": 33188,
      "old_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_rect_iPhone SE (3rd generation)_17.0_simulator.png",
      "new_id": "fca605741bb173d09311ca8a8836d34b69618322",
      "new_mode": 33188,
      "new_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_rect_iPhone SE (3rd generation)_17.0_simulator.png"
    },
    {
      "type": "modify",
      "old_id": "56ba9c59795639b274958311a7b1f20eb6a00589",
      "old_mode": 33188,
      "old_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_rrect_iPhone SE (3rd generation)_17.0_simulator.png",
      "new_id": "0d8f3cc70cb97e91a9a43843ca903910bb59505e",
      "new_mode": 33188,
      "new_path": "testing/scenario_app/ios/Scenarios/ScenariosUITests/golden_two_platform_view_clip_rrect_iPhone SE (3rd generation)_17.0_simulator.png"
    }
  ]
}