Google Git
Sign in
dart / external / github.com / flutter / engine / 3f40c68757ecf437f561d3fac7dc9d83b7cc8e21
commit3f40c68757ecf437f561d3fac7dc9d83b7cc8e21[log] [tgz]
authorHåkon Bertheussen <haakon@bertheussen.com>Thu Jun 27 20:44:04 2024 +0200
committerGitHub <noreply@github.com>Thu Jun 27 18:44:04 2024 +0000
treeb321b6d1ddd9d3355a558f068210cd52b7cd1f28
parentd1506c12808ec42e1b277376c4c2b1bd4ec20ac7 [diff]
Fix AccessibilityFeatures.disableAnimations flag on Android 12+ (#53428)

This PR fixes the problem where Flutter would not respect the "remove animation" accessibility setting on Android 12+.

Please see this issue for details: https://github.com/flutter/flutter/issues/130976

As [mentioned](https://github.com/flutter/flutter/issues/130976#issuecomment-1931388665) by [horsemankukka](https://github.com/horsemankukka), the problem has to do with reading `Settings.Global.TRANSITION_ANIMATION_SCALE` as a string instead of a float. Flutter would compare it to the string "0" to determine if animations should be disabled. Presumably, this worked because the settings app did indeed use the string "0" or "1" for this setting. But as of Android 12 it's instead written using float representation ("0.0" or "1.0"), at least on Samsung devices. [The documentation](https://developer.android.com/reference/android/provider/Settings.Global#TRANSITION_ANIMATION_SCALE) also states that this setting should be read as a float, which is what this PR does.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2 files changed
tree: b321b6d1ddd9d3355a558f068210cd52b7cd1f28
  1. .github/
  2. assets/
  3. benchmarking/
  4. bin/
  5. build/
  6. build_overrides/
  7. ci/
  8. common/
  9. display_list/
  10. docs/
  11. examples/
  12. flow/
  13. flutter_frontend_server/
  14. flutter_vma/
  15. fml/
  16. impeller/
  17. lib/
  18. runtime/
  19. shell/
  20. skia/
  21. sky/
  22. testing/
  23. third_party/
  24. tools/
  25. vulkan/
  26. wasm/
  27. web_sdk/
  28. .ci.yaml
  29. .clang-format
  30. .clang-tidy
  31. .clangd
  32. .engine-release.version
  33. .gitattributes
  34. .gitignore
  35. .pylintrc
  36. .style.yapf
  37. analysis_options.yaml
  38. AUTHORS
  39. BUILD.gn
  40. CODEOWNERS
  41. CONTRIBUTING.md
  42. DEPS
  43. Doxyfile
  44. LICENSE
  45. README.md
README.md

Flutter Engine

Flutter CI Status OpenSSF Scorecard SLSA 1

Flutter is Google's SDK for crafting beautiful, fast user experiences for mobile, web, and desktop from a single codebase. Flutter works with existing code, is used by developers and organizations around the world, and is free and open source.

The Flutter Engine is a portable runtime for hosting Flutter applications. It implements Flutter's core libraries, including animation and graphics, file and network I/O, accessibility support, plugin architecture, and a Dart runtime and compile toolchain. Most developers will interact with Flutter via the Flutter Framework, which provides a modern, reactive framework, and a rich set of platform, layout and foundation widgets.

If you want to run/contribute to Flutter Web engine, more tooling can be found at felt. This is a tool written to make web engine development experience easy.

If you are new to Flutter, then you will find more general information on the Flutter project, including tutorials and samples, on our Web site at Flutter.dev. For specific information about Flutter's APIs, consider our API reference which can be found at the docs.flutter.dev.

Flutter is a fully open source project, and we welcome contributions. Information on how to get started can be found at our contributor guide.