)]}'
{
  "commit": "3348fb0ca30286d370d6b816dd866ba5de795df6",
  "tree": "6c550bbce273c8b1006dfd8ac8ea405c245cbc51",
  "parents": [
    "f3e9b38a25884704e391a3381487a353e9dcaa69"
  ],
  "author": {
    "name": "Matan Lurey",
    "email": "matanlurey@users.noreply.github.com",
    "time": "Mon Nov 20 16:43:28 2023 -0800"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Mon Nov 20 16:43:28 2023 -0800"
  },
  "message": "[Impeller] Try replacing `*desc` with value/is_valid checks. (#48194)\n\nSome discussion here:\r\nhttps://discord.com/channels/608014603317936148/1175215129135153202.\r\n\r\nIn short, `*\u003cstd::optional\u003e` is [undefined\r\nbehavior](https://en.cppreference.com/w/cpp/utility/optional/operator*).\r\nAfter talking to @bdero we are considering that this should never\r\nhappen.\r\n\r\nI thought of a few different approaches here, none of them are great.\r\nHowever given that this class is used quite minimally, this seems to\r\njive with similar patterns we\u0027re using in scene/scene_context.\r\n\r\n---\r\n\r\nFeel free to push back or suggest alternatives, mostly proposing this to\r\nget brain juices flowing.",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "66c8b07db1989e1febfb38afcf0c6fc5a8f5d135",
      "old_mode": 33188,
      "old_path": "impeller/scene/scene_context.cc",
      "new_id": "baece932832a21c51734aa16c2cc539280919e5b",
      "new_mode": 33188,
      "new_path": "impeller/scene/scene_context.cc"
    },
    {
      "type": "modify",
      "old_id": "615ec4a4be5eda64f8db4f8d70dcd61faf0c0357",
      "old_mode": 33188,
      "old_path": "impeller/scene/scene_context.h",
      "new_id": "f85663b426770ea5a0de92acb5c62a6c42e6ba44",
      "new_mode": 33188,
      "new_path": "impeller/scene/scene_context.h"
    }
  ]
}