| commit | 23763db7227244cc5e443a0b49a1432b01b99fd0 | [log] [tgz] |
|---|---|---|
| author | Chinmay Garde <chinmaygarde@google.com> | Fri Feb 02 16:06:36 2024 -0800 |
| committer | GitHub <noreply@github.com> | Sat Feb 03 00:06:36 2024 +0000 |
| tree | 7be0763f32f970b0b532fb065c7a7783d4dbc833 | |
| parent | 7c372f492e628e399e83476fb8492a3775480958 [diff] |
[Impeller] Fix blown stack due to always out of date window dimensions on high-dpi devices. (#50307) This regression was introduced in https://github.com/flutter/engine/commit/89077a09c7f0d5691f7f5ed060481dc81dea74d0 which made it so that the updated surface size would be provided to the swapchain impl out-of-band instead of being inferred from the surface properties (to avoid a lag between the reports of the two). However, the playgrounds used the window size to report the updated size. This is fine where the window scale is 1. But fails on high-dpi devices. The patch replaces the call to get the window size with an equivalent call to get the framebuffer size. The failure was a blown stack due to a new swapchain impl being created over and over again because the size was always out of date. Fixes https://github.com/flutter/flutter/issues/142833
Flutter is Google's SDK for crafting beautiful, fast user experiences for mobile, web, and desktop from a single codebase. Flutter works with existing code, is used by developers and organizations around the world, and is free and open source.
The Flutter Engine is a portable runtime for hosting Flutter applications. It implements Flutter's core libraries, including animation and graphics, file and network I/O, accessibility support, plugin architecture, and a Dart runtime and compile toolchain. Most developers will interact with Flutter via the Flutter Framework, which provides a modern, reactive framework, and a rich set of platform, layout and foundation widgets.
If you want to run/contribute to Flutter Web engine, more tooling can be found at felt. This is a tool written to make web engine development experience easy.
If you are new to Flutter, then you will find more general information on the Flutter project, including tutorials and samples, on our Web site at Flutter.dev. For specific information about Flutter's APIs, consider our API reference which can be found at the docs.flutter.dev.
Flutter is a fully open source project, and we welcome contributions. Information on how to get started can be found at our contributor guide.