tree c6b0289e2dab8b7a355d625bf0ade45ec260cae5
parent b38abb81337b10c4b675d418e50f82a5fe6a894d
author Jacob MacDonald <jakemac@google.com> 1738619200 -0800
committer GitHub <noreply@github.com> 1738619200 -0800
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJnoTlACRC1aQ7uu5UhlAAAE1MQAKT59P8qSju1G7M8rn7VhZpM
 yBcZeqMoL/hT4UcAh+Jl5z042GvZgQqlkALmWwljSQ+RIBvfmhSfJIxsfQGSKCA2
 RvDREcjrXOfVq/h2GjC2Wwm1x+rs/dE2QqfXBUntlq3JE4gYFxUvxLSNCobtEUjo
 QVRvk/B5fwi6XrlPvra+JfTnbPramMoDgtUi6OdqXHZeDJ5kd84mfJlmgOWC+nW5
 1GR94+Ln2oR9HjwysKq3m6XW3MatKxguZd1AWXmj3xKVbaZykE2L1sFgK+I1B+tJ
 1KmJPnYohra7zlJNCSCLA3xOYOsHCnzwu+vPXtSynqurLu56iuSvJerGDJIYOKhV
 oQZEIKeaaksFyDaj8K3teq5G6ZtFQBmNFDlGKSeq5oel1tckaR+kuqKP/zde8YUD
 kk/rk//sGoXvdDeWqkZ+Xra0c7dMJ4ejE3PqB0yUGpJXq2yp4N1L5QKtKGZah3zV
 TlKecNXeS5dGLNY2+WXsTrO6bLrfFDOyNrOGK6MwdeqMnBdLbFlF9u613Gu0DuTc
 2isP1NzxAyC62K8HIcHN/SHn3L4K6bDR/UzYqa97TnrijeJotjtiIXIJpAcV2uSh
 A/doAI5xTBUq4PZlp9HLjbpxpE81HuEhPheqE8pxReWxIQXp9vmjyAwqAuEmS7CR
 6/30UBCqb5HljmSFcgbE
 =32Ol
 -----END PGP SIGNATURE-----
 

optimize cpu_profile_transformer to not create intermediate lists (#8839)

Uses an iterator over the stack frame values in CpuProfileTransformer, instead of allocating new lists for they keys and values in the map, which are then read by index. I also removed the late/nullable fields in favor of local variables, since the state was never used outside of a single method call.

As far as I could tell the keys were never actually used except to look up values in the map, so I dropped that entirely. There was an extra lookup in the map and local variable which I am pretty certain wasn't needed.

This isn't directly related to any specific issue, I just noticed it as I was perusing through some of the code for the cpu profiler and figured I would send something out, to dip my toes in here :).

No tests were added, the behavior should be unchanged so hopefully existing tests should cover it.

I did also add a TODO because I noticed a piece of logic that was O(N^2) worst case here but I don't know enough about how large the N is expected to be or whether its a common path, and it would be more involved to fix.