Google GitGoogle Git
Sign in
dart/ecosystem/16dca7ae5d3ff896a4db47e1ed6cd50f7ebbf115
commit
16dca7ae5d3ff896a4db47e1ed6cd50f7ebbf115
[log]
author
Kevin Moore <kevmoo@users.noreply.github.com>
Mon Sep 21 08:04:10 2026 -0700
committer
GitHub <noreply@github.com>
Mon Sep 21 15:04:10 2026 +0000
tree
b54cf2cdaf33c6e449e06c2a527dbcde406dce7e
parent
1bdafd85bb97b331ddd683577f48a5dfa7f4cb49 [diff]
fix(firehose): keep dart_apitool crash details in logs and sanitize breaking table row (#461)

When `dart_apitool` fails to produce `report.json` (for example, when analyzing packages that use Dart 3.13 shorthand factory constructors under `analyzer 10.2.0`), `Health.breakingChangeCheck` previously interpolated the entire raw `stderr` output (including multi-line `ExecutableDeclaration.toString()` dumps and stack traces) directly into `BreakingChange.explanation` alongside `neededVersion: Version(0, 0, 0)`. Because `BreakingChange.toMarkdownRow()` did not sanitize newlines or pipe characters, the multi-line stack trace shattered the PR Health comment's Markdown table.

- Keep full `stderr` diagnostics in the GitHub Actions workflow logs (via `runDashProcess` and `log(...)`).
- Set `neededVersion: null`, preserve `package.version` for `newVersion`, and emit a concise single-line message (`Unable to calculate breaking changes (see workflow logs for details).`) in the PR comment table when `report.json` is not created.
- Sanitize newlines (`\r?\n`) and pipe characters (`|`) in `BreakingChange.toMarkdownRow()` so multi-line explanations can never break the Markdown table structure.
- Add unit test coverage for `BreakingChange.toMarkdownRow()`.

Fixes https://github.com/dart-lang/ecosystem/issues/460
Related: https://github.com/bmw-tech/dart_apitool/issues/266
3 files changed
tree: b54cf2cdaf33c6e449e06c2a527dbcde406dce7e
  1. .github/
  2. .vscode/
  3. pkgs/
  4. .gitattributes
  5. .gitignore
  6. CODEOWNERS
  7. CONTRIBUTING.md
  8. LICENSE
  9. README.md
README.md

Overview

This repository is home to general Dart Ecosystem tools and packages.

Packages

PackageDescriptionVersion
blast_repoA tool to bulk validate and fix GitHub repos.
canaryTest package upgrades against the ecosystem.
corpusA tool to calculate the API usage for a package.
dart_flutter_team_lintsAn analysis rule set used by the Dart and Flutter teams.pub package
firehoseA tool to automate publishing of Pub packages from GitHub actions.pub package
repo_manageMiscellaneous issue, repo, and PR query tools.
sdk_triage_botA triage automation tool for dart-lang/sdk issues.
trebuchetA tool for moving existing packages into monorepos.

Dart mono-repos

Here's an overview of the main Dart team repositories:

Main repoDescription
sdkThe Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
SLO mono-reposDescription
coreThis repository is home to core Dart packages.
toolsThis repository is home to tooling related Dart packages.
labsThis repository is home to Dart ‘labs’ packages.
Topic mono-reposDescription
buildA build system for Dart written in Dart
ecosystemThis repository is home to general Dart Ecosystem tools and packages.
httpA composable API for making HTTP requests in Dart.
i18nA general mono-repo for Dart i18n and l10n packages.
leak_trackerA framework for memory leak tracking for Dart and Flutter applications.
macrosA Dart mono-repo for macro development.
nativeDart packages related to FFI and native assets bundling.
shelfWeb server middleware for Dart
testA library for writing unit tests in Dart.
webdevA CLI for Dart web development.

Publishing automation

For information about our publishing automation and release process, see https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

For additional information about contributing, see our contributing page.