commit 15b2a6ab507925552a4bf26a5acbffa17aa69caf
author Keerti Parthasarathy <keertip@users.noreply.github.com> Tue Sep 03 09:30:17 2019 -0600
committer GitHub <noreply@github.com> Tue Sep 03 09:30:17 2019 -0600
tree 61c8f088134afea1bd24eb0c41081362759b15fc
parent eb2d5e2fd9431013e065ac0115266feaba516ae9

Fix analysis hints (#2014)

lib/src/model.dart

diff --git a/lib/src/model.dart b/lib/src/model.dart
index eed06ba..39ac7ae 100644
--- a/lib/src/model.dart
+++ b/lib/src/model.dart
@@ -5671,7 +5671,7 @@
       lib ??= Library(e.enclosingElement.library, packageGraph);
       // (TODO:keertip) Find a better way to exclude members of extensions
       //  when libraries are specified using the "--include" flag
-      if (lib?.isDocumented) {
+      if (lib?.isDocumented == true) {
         return ModelElement.from(e, lib, packageGraph);
       }
     }

test/model_test.dart

diff --git a/test/model_test.dart b/test/model_test.dart
index 031618f..10e4364 100644
--- a/test/model_test.dart
+++ b/test/model_test.dart
@@ -2100,13 +2100,12 @@
   });
 
   group('Extension', () {
-    Extension ext, anExt, fancyList;
+    Extension ext, fancyList;
     Method s;
     List<Extension> extensions;
 
     setUpAll(() {
       ext = exLibrary.extensions.firstWhere((e) => e.name == 'AppleExtension');
-      anExt = exLibrary.extensions.firstWhere((e) => e.name == 'AnExtension');
       fancyList = exLibrary.extensions.firstWhere((e) => e.name == 'FancyList');
       extensions = exLibrary.publicExtensions.toList();
     });