Make DartFormatter.lineEnding immutable. (#1878)

Make DartFormatter.lineEnding immutable.

This property was always intended to be semantically immutable but
since the early days, it was exposed as a public writable field.

This retains the setter to avoid a compile-time breaking change in the
off chance there is some code calling the setter, but invoking it does
nothing.

This also fixes the weird behavior where if you omit a line ending
(which I'm guessing all users do), it infers the line ending from the
first format() call and then persists that to later calls. This is a
weird subtle kind of mutability. In practice, it's harmless because
users rarely reuse a DartFormatter instance to format code with
different line endings. But it never felt like a good design.

This is technically a breaking change, but in a corpus of 2,000 pub
packages, I couldn't find a single reference to an identifier named
"lineEnding", so I suspect no code in the wild will actually break,
which is why I only bumped the patch version.

Fix #1337.
11 files changed
tree: b2d305b7bc978e870f83d384d5b30e5f2f5239d0
  1. .github/
  2. benchmark/
  3. bin/
  4. dist/
  5. example/
  6. lib/
  7. test/
  8. tool/
  9. .gitignore
  10. analysis_options.yaml
  11. AUTHORS
  12. CHANGELOG.md
  13. LICENSE
  14. pubspec.yaml
  15. README.md
README.md

The dart_style package defines an opinionated, minimally configurable automated formatter for Dart code.

It replaces the whitespace in your program with what it deems to be the best formatting for it. It also makes minor changes around non-semantic punctuation like trailing commas and brackets in parameter lists.

The resulting code should follow the Dart style guide and look nice to most human readers, most of the time.

The formatter handles indentation, inline whitespace, and (by far the most difficult) intelligent line wrapping. It has no problems with nested collections, function expressions, long argument lists, or otherwise tricky code.

The formatter turns code like this:

process = await Process.start(path.join(p.pubCacheBinPath,Platform.isWindows
?'${command.first}.bat':command.first,),[...command.sublist(1),'web:0',
// Allow for binding to a random available port.
],workingDirectory:workingDir,environment:{'PUB_CACHE':p.pubCachePath,'PATH':
path.dirname(Platform.resolvedExecutable)+(Platform.isWindows?';':':')+
Platform.environment['PATH']!,},);

into:

process = await Process.start(
  path.join(
    p.pubCacheBinPath,
    Platform.isWindows ? '${command.first}.bat' : command.first,
  ),
  [
    ...command.sublist(1), 'web:0',
    // Allow for binding to a random available port.
  ],
  workingDirectory: workingDir,
  environment: {
    'PUB_CACHE': p.pubCachePath,
    'PATH':
        path.dirname(Platform.resolvedExecutable) +
        (Platform.isWindows ? ';' : ':') +
        Platform.environment['PATH']!,
  },
);

The formatter will never break your code—you can safely invoke it automatically from build and presubmit scripts.

Formatting files

The formatter is part of the unified dart developer tool included in the Dart SDK, so most users run it directly from there using dart format.

IDEs and editors that support Dart usually provide easy ways to run the formatter. For example, in Visual Studio Code, formatting Dart code will use the dart_style formatter by default. Most users have it set to reformat every time they save a file.

Here's a simple example of using the formatter on the command line:

$ dart format my_file.dart

This command formats the my_file.dart file and writes the result back to the same file.

The dart format command takes a list of paths, which can point to directories or files. If the path is a directory, it processes every .dart file in that directory and all of its subdirectories.

By default, dart format formats each file and writes the result back to the same files. If you pass --output show, it prints the formatted code to stdout and doesn't modify the files.

Validating formatting

If you want to use the formatter in something like a presubmit script or commit hook, you can pass flags to omit writing formatting changes to disk and to update the exit code to indicate success/failure:

$ dart format --output=none --set-exit-if-changed .

Using the formatter as a library

The dart_style package exposes a simple library API for formatting code. Basic usage looks like this:

import 'package:dart_style/dart_style.dart';

main() {
  final formatter = DartFormatter(
    languageVersion: DartFormatter.latestLanguageVersion,
  );

  try {
    print(formatter.format("""
    library an_entire_compilation_unit;

    class SomeClass {}
    """));

    print(formatter.formatStatement("aSingle(statement);"));
  } on FormatterException catch (ex) {
    print(ex);
  }
}

Other resources

  • Before sending an email, see if you are asking a frequently asked question.

  • Before filing a bug, or if you want to understand how work on the formatter is managed, see how we track issues.