tree 2f5b2eeb7eaae4aee101d9d3a2f77a141c0bf83f
parent 42b9bd428e37ae166080fa837ce45c178f3391e9
author Bob Nystrom <rnystrom@google.com> 1707765864 -0800
committer GitHub <noreply@github.com> 1707765864 -0800
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJlynBoCRC1aQ7uu5UhlAAAbUkQAKrUiT6NJqAbZPgeAljyCfer
 FeIZi5J6trpLl9i6FwQXZMbHYtm70TJXqW7m82trZ+1+WGekSajB2jrDymGnp8YD
 /yeMd/y8E6ZISYoBhkTMNFHW7dnTME6+tHG4nedfJUufBrZakNVjbPmzKGaYIMXE
 hOY17Wawoxjeri1RgK/EY1vndP78MhhCk4Ad7Q07R8QDhmZKUcQtQAHaOEZ6HQo/
 f81aNc5r1uPYqg7685iy6EuTLVl+RUW9K1KIN7k3KUlJ9PWHVYZ8BOrRHgnoXQYY
 /WKT5FxXUfMVKy3YKFQrE7fd133Rs7CSF2Jt1+dMxWgD1k5f9Ux8hTmTkQQAJr3E
 2B9+r3cAETyaRSk8pjYHIT+1Wl+INNqIZ8HrhNzW1EtohJ4dwNiJUSuBOTdL2Dnx
 Jn4jeeps6D6p4OWDAGxyqDjXVQ/MvwNjdltC/f2bMEc6PKf5tfEwBdEdNqhNSWji
 1nsv4R0+7aZ+ylOQhuPQhFMGKBEKyrD3YUUl3DJh6V0b93xhM8W2QgR0m4FcHuAq
 ue02VLNFTs7nlQDPVGLAJTMWfIrvGr1cb0Gy9g/Cqn0j00YEI2fE0e42g5GiDJdC
 T+IfhS2hNpeJnKq7yfp82rjIs7svAvxAkbmhrSs0DW/dEQ0+vKVqzGdYKqse6NCx
 jkIXjujr6g3ZKH2Hwz8h
 =zYTc
 -----END PGP SIGNATURE-----
 

Prefer any valid solution over an invalid one, regardless of overflow. (#1379)

While the Solver is working through Solutions, it keeps track of the
best Solution it's found so far. This will get returned if there is no
Solution that fits within the page width: when overflow is inevitable,
the formatter still tries to do the best it can.

The Solver is careful to not consider an invalid solution (one that
contains a newline where none is allowed) to be the best solution.
Except in one case: If the *initial* solution is invalid, the Solver
will still store it in best. Then, as long as no other solution has
less overflow than the initial invalid one, it ends up returning an
invalid solution.

This fixes that: any valid solution, regardless of overflow, will kick
out that initial invalid solution if there is one.