commit | d301b33058c5ed202dd8b926c706de9418874113 | [log] [tgz] |
---|---|---|
author | Bob Nystrom <rnystrom@google.com> | Wed May 01 14:04:42 2024 -0700 |
committer | GitHub <noreply@github.com> | Wed May 01 14:04:42 2024 -0700 |
tree | 2c3cf49fda20828fcda1a4fffad79f060b253f9d | |
parent | 709a211a2ce4b764dbfcc17d861357852f471d70 [diff] |
Bind pieces based on page width during formatting. (#1455) One important optimization to avoid trying a bunch of dead end solutions is to see if we can eagerly determine that a piece will always end up in some state based on just the size of its contents and the page width. In order to apply that optimization, we walk the piece tree when constructing the solution and ask each piece if it can be eagerly bound. Unfortunately, that traversal itself has significant overhead: ``` Times (ms) AstNodeVisitor build Piece tree = 777.852 AstNodeVisitor.run() = 4166.931 CodeWriter.format() write separate piece text = 46.461 PieceWriter.finish() format piece tree = 3383.440 Solution bind by page width = 442.435 Solution.mergeSubtree() = 110.427 Solver dequeue = 74.833 Solver enqueue = 58.036 Whole enchilada = 5147.055 ``` That's the "Solution bind by page width" step here. This PR gets rid of the separate eager traversal. Instead, when we reach a piece during formatting, if it isn't already bound, we try the eager binding optimization then. That yields: ``` Times (ms) AstNodeVisitor build Piece tree = 790.935 AstNodeVisitor.run() = 3944.811 CodeWriter try to bind by page width = 145.603 CodeWriter.format() write separate piece text = 45.283 PieceWriter.finish() format piece tree = 3151.060 Solution.mergeSubtree() = 119.708 Solver dequeue = 74.775 Solver enqueue = 56.464 Whole enchilada = 4813.870 ``` The binding step is now "CodeWriter try to bind by page width" and is much faster. This improves the overall performance when formatting the Flutter repo from 3.575s to 3.325s, or 7.5% faster. Some of the benchmarks show a more significant improvement: ``` Benchmark (tall) fastest median slowest average baseline ----------------------------- -------- ------- ------- ------- -------- block 0.076 0.079 0.151 0.083 119.1% chain 2.505 2.536 2.616 2.538 99.0% collection 0.161 0.169 0.316 0.175 115.3% collection_large 0.910 0.955 1.033 0.954 131.0% flutter_popup_menu_test 0.466 0.483 0.774 0.494 117.3% flutter_scrollbar_test 0.149 0.154 0.184 0.156 155.3% function_call 1.497 1.534 1.678 1.537 132.9% infix_large 1.525 1.552 1.624 1.555 111.4% infix_small 0.315 0.327 0.356 0.329 116.7% interpolation 0.107 0.113 0.239 0.121 113.6% large 4.648 4.750 5.032 4.755 121.2% top_level 0.256 0.264 0.340 0.269 104.7% ``` Not bad for a small code change.
The dart_style package defines an automatic, opinionated formatter for Dart code. It replaces the whitespace in your program with what it deems to be the best formatting for it. Resulting code should follow the Dart style guide but, moreso, should look nice to most human readers, most of the time.
The formatter handles indentation, inline whitespace, and (by far the most difficult) intelligent line wrapping. It has no problems with nested collections, function expressions, long argument lists, or otherwise tricky code.
The formatter turns code like this:
// BEFORE formatting if (tag=='style'||tag=='script'&&(type==null||type == TYPE_JS ||type==TYPE_DART)|| tag=='link'&&(rel=='stylesheet'||rel=='import')) {}
into:
// AFTER formatting if (tag == 'style' || tag == 'script' && (type == null || type == TYPE_JS || type == TYPE_DART) || tag == 'link' && (rel == 'stylesheet' || rel == 'import')) {}
The formatter will never break your code—you can safely invoke it automatically from build and presubmit scripts.
The formatter can also apply non-whitespace changes to make your code consistently idiomatic. You must opt into these by passing either --fix
which applies all style fixes, or any of the --fix-
-prefixed flags to apply specific fixes.
For example, running with --fix-named-default-separator
changes this:
greet(String name, {String title: "Captain"}) { print("Greetings, $title $name!"); }
into:
greet(String name, {String title = "Captain"}) { print("Greetings, $title $name!"); }
The formatter is part of the unified dart
developer tool included in the Dart SDK, so most users get it directly from there. That has the latest version of the formatter that was available when the SDK was released.
IDEs and editors that support Dart usually provide easy ways to run the formatter. For example, in WebStorm you can right-click a .dart file and then choose Reformat with Dart Style.
Here's a simple example of using the formatter on the command line:
$ dart format test.dart
This command formats the test.dart
file and writes the result to the file.
dart format
takes a list of paths, which can point to directories or files. If the path is a directory, it processes every .dart
file in that directory or any of its subdirectories.
By default, it formats each file and write the formatting changes to the files. If you pass --output show
, it prints the formatted code to stdout.
You may pass a -l
option to control the width of the page that it wraps lines to fit within, but you're strongly encouraged to keep the default line length of 80 columns.
If you want to use the formatter in something like a presubmit script or commit hook, you can pass flags to omit writing formatting changes to disk and to update the exit code to indicate success/failure:
$ dart format --output=none --set-exit-if-changed .
If you need to run a different version of the formatter, you can globally activate the package from the dart_style package on pub.dev:
$ pub global activate dart_style $ pub global run dart_style:format ...
The package also exposes a single dart_style library containing a programmatic API for formatting code. Simple usage looks like this:
import 'package:dart_style/dart_style.dart'; main() { final formatter = DartFormatter(); try { print(formatter.format(""" library an_entire_compilation_unit; class SomeClass {} """)); print(formatter.formatStatement("aSingle(statement);")); } on FormatterException catch (ex) { print(ex); } }
Before sending an email, see if you are asking a frequently asked question.
Before filing a bug, or if you want to understand how work on the formatter is managed, see how we track issues.