Google Git
Sign in
dart / dart_style / 6b2b31e55b6a50f4d6ff356b0e085ef2e4345de4
commit6b2b31e55b6a50f4d6ff356b0e085ef2e4345de4[log] [tgz]
authorBob Nystrom <rnystrom@google.com>Tue Feb 27 11:17:59 2024 -0800
committerGitHub <noreply@github.com>Tue Feb 27 11:17:59 2024 -0800
treeeab285eeaacd67d194064566a9b622ae4913655a
parentbe7eb5e42e52959417f4455e878e73c649a24016 [diff]
Don't eagerly bind pinned Pieces in Solution. (#1407)

Before this change, constructor for Solution would recursively traverse
the entire piece tree from the root down. It did so looking for pieces
that were pinned, so that it could add them to the pieceState map and
(more importantly) apply any constraints that the pinned piece's state
implies on other child pieces.

Unfortunately, this traversal interacts poorly with the optimization to
format some piece subtrees separately. The Solution constructor for the
root piece would traverse the whole tree, then Solution constructors for
any child pieces being formatted separately would also traverse their
piece trees, and so on.

In practice, it was roughly quadratic. Oops. :(

This change removes that traversal completely. Instead, when a piece is
pinned, we apply any constraints at that point in time and then pin the
constrained pieces.

Then, during solving, Solution looks to see if the piece has a pinned
state before looking at its own bound state map. That way, we never have
to bother redundantly storing the states of pinned pieces in the state
map.

On my machine, this makes the large benchmark about 17% faster.
2 files changed
tree: eab285eeaacd67d194064566a9b622ae4913655a
  1. .github/
  2. benchmark/
  3. bin/
  4. dist/
  5. example/
  6. lib/
  7. test/
  8. tool/
  9. .gitignore
  10. analysis_options.yaml
  11. AUTHORS
  12. CHANGELOG.md
  13. LICENSE
  14. pubspec.yaml
  15. README.md
README.md

The dart_style package defines an automatic, opinionated formatter for Dart code. It replaces the whitespace in your program with what it deems to be the best formatting for it. Resulting code should follow the Dart style guide but, moreso, should look nice to most human readers, most of the time.

The formatter handles indentation, inline whitespace, and (by far the most difficult) intelligent line wrapping. It has no problems with nested collections, function expressions, long argument lists, or otherwise tricky code.

The formatter turns code like this:

// BEFORE formatting
if (tag=='style'||tag=='script'&&(type==null||type == TYPE_JS
      ||type==TYPE_DART)||
  tag=='link'&&(rel=='stylesheet'||rel=='import')) {}

into:

// AFTER formatting
if (tag == 'style' ||
  tag == 'script' &&
      (type == null || type == TYPE_JS || type == TYPE_DART) ||
  tag == 'link' && (rel == 'stylesheet' || rel == 'import')) {}

The formatter will never break your code—you can safely invoke it automatically from build and presubmit scripts.

Style fixes

The formatter can also apply non-whitespace changes to make your code consistently idiomatic. You must opt into these by passing either --fix which applies all style fixes, or any of the --fix--prefixed flags to apply specific fixes.

For example, running with --fix-named-default-separator changes this:

greet(String name, {String title: "Captain"}) {
  print("Greetings, $title $name!");
}

into:

greet(String name, {String title = "Captain"}) {
  print("Greetings, $title $name!");
}

Using the formatter

The formatter is part of the unified dart developer tool included in the Dart SDK, so most users get it directly from there. That has the latest version of the formatter that was available when the SDK was released.

IDEs and editors that support Dart usually provide easy ways to run the formatter. For example, in WebStorm you can right-click a .dart file and then choose Reformat with Dart Style.

Here's a simple example of using the formatter on the command line:

$ dart format test.dart

This command formats the test.dart file and writes the result to the file.

dart format takes a list of paths, which can point to directories or files. If the path is a directory, it processes every .dart file in that directory or any of its subdirectories.

By default, it formats each file and write the formatting changes to the files. If you pass --output show, it prints the formatted code to stdout.

You may pass a -l option to control the width of the page that it wraps lines to fit within, but you're strongly encouraged to keep the default line length of 80 columns.

Validating files

If you want to use the formatter in something like a presubmit script or commit hook, you can pass flags to omit writing formatting changes to disk and to update the exit code to indicate success/failure:

$ dart format --output=none --set-exit-if-changed .

Running other versions of the formatter CLI command

If you need to run a different version of the formatter, you can globally activate the package from the dart_style package on pub.dev:

$ pub global activate dart_style
$ pub global run dart_style:format ...

Using the dart_style API

The package also exposes a single dart_style library containing a programmatic API for formatting code. Simple usage looks like this:

import 'package:dart_style/dart_style.dart';

main() {
  final formatter = DartFormatter();

  try {
    print(formatter.format("""
    library an_entire_compilation_unit;

    class SomeClass {}
    """));

    print(formatter.formatStatement("aSingle(statement);"));
  } on FormatterException catch (ex) {
    print(ex);
  }
}

Other resources

  • Before sending an email, see if you are asking a frequently asked question.

  • Before filing a bug, or if you want to understand how work on the formatter is managed, see how we track issues.