tree 23e8b32917fa3be54154d5eb70f69e4fe8a3a29c
parent 222f670f40a1b3f10e15df936b25793454d9b900
author Bob Nystrom <rnystrom@google.com> 1715723094 -0700
committer GitHub <noreply@github.com> 1715723094 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJmQ9tWCRC1aQ7uu5UhlAAAWlMQAIg3gBZBJTsz4KTBBDvUf1iP
 3bGTNbtqqD1IO00ov3lShO5sDD9D2vayZzsqICvmsSYzXXN8hwv4Tctih/JfZIvr
 f00liJ/xnyz2VnKPia7jfvG61tefsY6ZNjA5wNQyYlA7xaGbUoC1v+J+DHrNq2lU
 wijjWn2sRZv4tfgR2ZIi881B/kyagDsZC/73rjhuIGCHr5q7KIOSfCuiC8RON9hJ
 gVy7dMWtkYtNHlFf928qetDvp8rhLcTz7ETbqpEl9jY0WgbPGBwKAHgEkeT8/xiR
 1hgSlogR7pcQmGDYhcq4X5DmjqHoDcxwQRTWo9iuMkTEC3YR5H/i6RlIzkgMzxBU
 q2VHQVBTvUZtyMzEujGFr/isumt7yGtgbiIUfchhUJBWqCWPKbRsBmVod9ukL1ws
 6ohPnEifL+s7bXAJmdnzJdm1/6UgRsVsNbNv0WzgH74fYOcGJPIzAWD28fp01Xco
 KcesW3hswKT51YnwNCvaQ3CNdBL+WJfncmzfX926VxDKymdVWRzJ3oRkTnPUMH1e
 565kZZbmED9vVylr/uylJT3C4PAjMVe2jM9iCIU+KPkvEGdc3SBGW0NywJuQq9/d
 sedGBH+IkORT7A2qDwuB9o6BrO1f4hklokxVegUqvIgcSOl7254TgdHQ3gX/pATp
 bqEAmEtiLVTWQ6xmNKES
 =8qUO
 -----END PGP SIGNATURE-----
 

Don't use AssignPiece for for-in loop "in" clauses. (#1485)

Don't use AssignPiece for for-in loop "in" clauses.

One of the reasons that AssignPiece is so hairy is because it handles
both splitting after the operator ("=", ":", etc.) and before "in".

Splitting out for-in loops to their own Piece class lets us get rid of
a little of that complexity.

Also, I thought that was the only reason that the operator is a separate
Piece. That's actually not true because we also need the LHS to be its
own piece for applyConstraints().

Even so, I still think it's a little easier to understand with for-in
loops being their own piece.

I also slightly tweaked the formatting of for-in loops. In the rare
case where the left side block splits, we now indent it and split at
"in". This is consistent with the old style. I don't have a strong
preference, but I think it looks a little neater this way.

Co-authored-by: Nate Bosch <nbosch@google.com>