tree 3357c4c5a3cc3ad9943e33c86e86ee214dde3931
parent 166d3e07eabc8283c6137cfde17fb25b8bb40080
author Nate Bosch <nbosch1@gmail.com> 1598728228 -0700
committer GitHub <noreply@github.com> 1598728228 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJfSqgkCRBK7hj4Ov3rIwAAdHIIAGn5PmrLnP9/l0sKtXSnQTvm
 ZtGMKkrHyB7FABs8kjnIzj0sLMBxklD1R7agFrReknWyaW6XwZNYOzvTyzJX0k4E
 3Ewxr0MN6NK2lyBvL+gTi0ODqXs9oHEFPXadOp5ms/Q7Zb1hBHathNjGASxPBHg+
 sTtoMp6rJi408bgQAW45KDP9/KzrGoQ3MDii/dH0TcjGcbD1mq1B5IHF2wSKKMNG
 8t9bEbfdiEHHrbPNMUrLHjk/DuBhhueFRigU8bWl4D6VRoR/rsUKbK1uUbuvuGRD
 K3R+7K5pnBzhAj+4KLCR0H7BLxjfLIQUnkotrn+DuZAjb/XPAfoynXTIZSvw2q0=
 =SOvv
 -----END PGP SIGNATURE-----
 

Fix cast of nullable argument (#112)

The `as num` cast existed before the migration, but in the wrong place
so the overall expression was still `dynamic`. Implicit casts from
`dynamic` are still allowed, so it wasn't flagged that the cast was in
the wrong place - disabling implicit casts from dynamic makes it more
obvious that there is a problem, but doesn't fix the entire issue.

In addition to the cast being in the wrong place, it also was to the
wrong type. Casting to `num` instead of `num?` does not surface any
warnings because it's valid to pass the `num` to an argument wanting
`num?`.

This was not surfaced originally due to a bug in the VM which causes the
opt-in state of a package in the experiment allow list to _not_ control
the soundness when executing. Add explicit opt in test runs for now.
https://github.com/dart-lang/sdk/issues/43243