add invalid_runtime_check_with_js_interop_types to the recommended lint set (dart-lang/lints#199)
diff --git a/pkgs/lints/.github/workflows/validate.yml b/pkgs/lints/.github/workflows/validate.yml
index 1b70e81..3ae64df 100644
--- a/pkgs/lints/.github/workflows/validate.yml
+++ b/pkgs/lints/.github/workflows/validate.yml
@@ -17,7 +17,7 @@
strategy:
fail-fast: false
matrix:
- sdk: [3.4, stable, beta]
+ sdk: [3.5, stable, beta]
steps:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332
diff --git a/pkgs/lints/CHANGELOG.md b/pkgs/lints/CHANGELOG.md
index b77eb43..e37d3de 100644
--- a/pkgs/lints/CHANGELOG.md
+++ b/pkgs/lints/CHANGELOG.md
@@ -2,9 +2,11 @@
- `recommended`:
- added [unnecessary_library_name] (https://github.com/dart-lang/lints/issues/181)
-- Updated the SDK lower-bound to 3.4.
+ - added [invalid_runtime_check_with_js_interop_types] (https://github.com/dart-lang/lints/issues/188)
+- Updated the SDK lower-bound to 3.5.
[unnecessary_library_name]: https://dart.dev/lints/unnecessary_library_name
+[invalid_runtime_check_with_js_interop_types]: https://dart.dev/tools/linter-rules/invalid_runtime_check_with_js_interop_types
## 4.0.0
diff --git a/pkgs/lints/lib/recommended.yaml b/pkgs/lints/lib/recommended.yaml
index bf0d9cd..602ae5b 100644
--- a/pkgs/lints/lib/recommended.yaml
+++ b/pkgs/lints/lib/recommended.yaml
@@ -25,6 +25,7 @@
- empty_statements
- exhaustive_cases
- implementation_imports
+ - invalid_runtime_check_with_js_interop_types
- library_prefixes
- library_private_types_in_public_api
- no_leading_underscores_for_library_prefixes
diff --git a/pkgs/lints/pubspec.yaml b/pkgs/lints/pubspec.yaml
index cbe926d..7481937 100644
--- a/pkgs/lints/pubspec.yaml
+++ b/pkgs/lints/pubspec.yaml
@@ -10,7 +10,7 @@
- lints
environment:
- sdk: ^3.4.0
+ sdk: ^3.5.0
# NOTE: Code is not allowed in this package - do not add dependencies.
# dependencies:
diff --git a/pkgs/lints/rules.md b/pkgs/lints/rules.md
index 1d6eb5d..f48b389 100644
--- a/pkgs/lints/rules.md
+++ b/pkgs/lints/rules.md
@@ -59,6 +59,8 @@
| [`empty_statements`](https://dart.dev/lints/empty_statements) | Avoid empty statements. | ✅ |
| [`exhaustive_cases`](https://dart.dev/lints/exhaustive_cases) | Define case clauses for all constants in enum-like classes. | ✅ |
| [`implementation_imports`](https://dart.dev/lints/implementation_imports) | Don't import implementation files from another package. | |
+| [`invalid_runtime_check_with_js_interop_types`](https://dart.dev/lints/invalid_runtime_check_with_js_interop_types) | Avoid runtime type tests with JS interop types where the result may not
+ be platform-consistent. | |
| [`library_prefixes`](https://dart.dev/lints/library_prefixes) | Use `lowercase_with_underscores` when specifying a library prefix. | |
| [`library_private_types_in_public_api`](https://dart.dev/lints/library_private_types_in_public_api) | Avoid using private types in public APIs. | |
| [`no_leading_underscores_for_library_prefixes`](https://dart.dev/lints/no_leading_underscores_for_library_prefixes) | Avoid leading underscores for library prefixes. | ✅ |
diff --git a/pkgs/lints/tool/rules.json b/pkgs/lints/tool/rules.json
index 5a8d1ff..3fac4a2 100644
--- a/pkgs/lints/tool/rules.json
+++ b/pkgs/lints/tool/rules.json
@@ -296,7 +296,7 @@
},
{
"name": "comment_references",
- "description": "Only reference in scope identifiers in doc comments.",
+ "description": "Only reference in-scope identifiers in doc comments.",
"fixStatus": "hasFix"
},
{
@@ -531,7 +531,7 @@
},
{
"name": "no_literal_bool_comparisons",
- "description": "Don't compare booleans to boolean literals.",
+ "description": "Don't compare Boolean expressions to Boolean literals.",
"fixStatus": "hasFix"
},
{
@@ -580,6 +580,11 @@
"fixStatus": "hasFix"
},
{
+ "name": "omit_obvious_local_variable_types",
+ "description": "Omit obvious type annotations for local variables.",
+ "fixStatus": "hasFix"
+ },
+ {
"name": "one_member_abstracts",
"description": "Avoid defining a one-member abstract class when a simple function will do.",
"fixStatus": "noFix"
@@ -1086,7 +1091,7 @@
},
{
"name": "use_full_hex_values_for_flutter_colors",
- "description": "Prefer an 8-digit hexadecimal integer(0xFFFFFFFF) to instantiate Color.",
+ "description": "Prefer an 8-digit hexadecimal integer (for example, 0xFFFFFFFF) to instantiate a Color.",
"fixStatus": "hasFix"
},
{
@@ -1160,6 +1165,11 @@
"fixStatus": "noFix"
},
{
+ "name": "use_truncating_division",
+ "description": "Use truncating division.",
+ "fixStatus": "hasFix"
+ },
+ {
"name": "valid_regexps",
"description": "Use valid regular expression syntax.",
"fixStatus": "noFix"
