commit 2f28f2551f2f070aa36b0156418ae119352a8b05
author Michael Thomsen <mit@google.com> Tue May 25 14:38:59 2021 +0200
committer GitHub <noreply@github.com> Tue May 25 14:38:59 2021 +0200
tree 645274106027c356c7613bc394b2c184b420f9af
parent 315d71a2867d8ac9d06f583da6925465a588fa3f

Switch to package:lints (#53)

CHANGELOG.md

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6bf873e..0944a53 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,7 @@
 ## 1.1.1-dev
 
+* Switched from using lints in package:pedantic to package:lints.
+
 ## 1.1.0
 
 * Stable release for null safety.

analysis_options.yaml

diff --git a/analysis_options.yaml b/analysis_options.yaml
index dd48aa5..572dd23 100644
--- a/analysis_options.yaml
+++ b/analysis_options.yaml
@@ -1,7 +1 @@
-include: package:pedantic/analysis_options.1.9.0.yaml
-analyzer:
-  errors:
-    prefer_single_quotes: ignore
-    use_function_type_syntax_for_parameters: ignore
-  enable-experiment:
-    - non-nullable
+include: package:lints/recommended.yaml

lib/src/characters_impl.dart

diff --git a/lib/src/characters_impl.dart b/lib/src/characters_impl.dart
index c5fddee..0791ec0 100644
--- a/lib/src/characters_impl.dart
+++ b/lib/src/characters_impl.dart
@@ -116,13 +116,14 @@
   }
 
   @override
-  bool contains(Object? other) {
-    if (other is String) {
-      if (other.isEmpty) return false;
-      var next = Breaks(other, 0, other.length, stateSoTNoBreak).nextBreak();
-      if (next != other.length) return false;
-      // [other] is single grapheme cluster.
-      return _indexOf(string, other, 0, string.length) >= 0;
+  bool contains(Object? element) {
+    if (element is String) {
+      if (element.isEmpty) return false;
+      var next =
+          Breaks(element, 0, element.length, stateSoTNoBreak).nextBreak();
+      if (next != element.length) return false;
+      // [element] is single grapheme cluster.
+      return _indexOf(string, element, 0, string.length) >= 0;
     }
     return false;
   }

pubspec.yaml

diff --git a/pubspec.yaml b/pubspec.yaml
index c8706dc..0e5a5cf 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -8,4 +8,4 @@
 
 dev_dependencies:
   test: ^1.16.0
-  pedantic: ^1.10.0
+  lints: ^1.0.0

test/characters_test.dart

diff --git a/test/characters_test.dart b/test/characters_test.dart
index 98aa2e2..0b565bc 100644
--- a/test/characters_test.dart
+++ b/test/characters_test.dart
@@ -65,7 +65,7 @@
     var zwj = "\u200d"; // U+200D, ZWJ
     var rainbow = "\u{1f308}"; // U+1F308, Rainbow. Category Pictogram
 
-    testParts(gc("$flag$white$zwj$rainbow"), gc("$flag$white"), gc("$rainbow"),
+    testParts(gc("$flag$white$zwj$rainbow"), gc("$flag$white"), gc(rainbow),
         gc("$flag$zwj$rainbow"), gc("!"));
   });