tree dc81fd3c474677414dd2ec2c3002f72c5ecb31c9
parent 5737ad764bfce1ac14918944e7fb538cd674359e
author Nate Bosch <nbosch@google.com> 1620408799 -0700
committer GitHub <noreply@github.com> 1620408799 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJglXnfCRBK7hj4Ov3rIwAA3R4IAD4RNV5AjLnOb0vL3xJlU6xe
 1YH/1X2+m/zddZD26VihH/4Y7EFpH8uLtJ8VTUeKUvce89ABdr+l/iggTNLmXnKE
 0U3hJ0XS7LuwThBzkaRZBL/fPe4qH/pdnRFfkpsNw9JvL+BbGgwkOgM6c5UzhE1+
 5VPpZkFAtuiEykHcRGYRKeEhm7u7hN7ARDeiwmzBWxTHwSEDHjVT/Xh3E6DFAYfD
 HcudLvAOi6n6c3gXjjqHcG+NhfumL738vsMIy9nXe2VlQuHL5kbaQiBEkCnmoN5R
 s0IX2ulS31LeKJVMNUNf5xbpiDf9tCaB5ajMTdxQzJw8CDy6tdbkVKedK4eEpuU=
 =/F8l
 -----END PGP SIGNATURE-----
 

Don't invoke onValue for a canceled operation (#177)

Fixes #172

The `isCompleted` boolean does not necessarily indicate that
`valueOrCancellation` will complete with a value. If the completer was
completed with a `Future` and then canceled before that argument
invokes the listener callback, the `valueOrCancellation` future will
complete with `null` but `isCompleted` will be true. We only have a
value to pass to `onValue` when the completer was completed and not
canceled.

Add tests for the behavior of `then` when `cancel` is called after
`completer.complete`, both when it was completed with a Future and a
non-Future value.

Move the initialization for `originalCompleter` to the `setup` for the
tests so that it can be used before calling `then`.