tree 33340767bb833ef38e4b7eb4e2051abbec27c534
parent 1c720ed21abfd77a5178880c04f33e3f7d4abc18
author Nate Bosch <nbosch@google.com> 1616541232 -0700
committer GitHub <noreply@github.com> 1616541232 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJgWnYwCRBK7hj4Ov3rIwAAdHIIAF2wiIJ3mNnnSWH9fzB09zpQ
 BF3eTnVZu3rf/qvKoWYs+h4zt1Stkmmfp2VU1vMvNs2PRQXBgJekgVKKpmR0OMhu
 ojtUMxhFHoMTqG844VgEHUFNar+D2+63gfyvC56MT19E1tgFajGFZUMwBGV3CX2h
 g8tms7dgSNiMWbafb+HQqjx8KlHojwa2penDmKXHqMpTjMPsN75/I2nUukRNC/07
 liCw0BdBd7cVfQAPERhltRsvCxbIqYmKoEvAmaOGM9wFOOHgTDr4qX0QoagjyZSu
 u9LPYh1X4+15drynnCLRC1mhcT97YvMSfxic6Q1Ixyb9eY5JbC8vbtV58Fy+q3o=
 =FhpU
 -----END PGP SIGNATURE-----
 

Split parse* methods to avoid duplicate work (#185)

Each of the methods `parseSoloOption`, `parseAbbreviation`, and
`parseLongOption` do some string manipulation and checking, before
potentially calling the same method on their parent parser. No state
changes during parsing part. Split out a 'handle' method in each case
that takes a partially parsed result as arguments, and avoid duplicating
that work at each step in the parent chain. There may be other work that
could be avoided but it would take deeper refactoring. The
`parseShortFlag` does not need to be split since there are no
intermediate results computed from the String.

Make all possible members of `Parser` private.

Use a list literal for `_rest` in the initializer list instead of using `.addAll`
in the constructor body.